fix: do not register the plugin twice #183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 88.54% 86.66% -1.88%
==========================================
Files 3 3
Lines 192 180 -12
Branches 39 38 -1
==========================================
- Hits 170 156 -14
- Misses 20 22 +2
Partials 2 2
Continue to review full report at Codecov.
|
|
|
||
| this.preCompiler = webpack(config); | ||
| this.preCompiler.outputFileSystem = createFsFromVolume(new Volume()); | ||
| this.preCompiler.outputFileSystem.join = path.join.bind(path); |
There was a problem hiding this comment.
We should keep it otherwise webpack serve will not work
There was a problem hiding this comment.
can you clarify(maybe I misunderstood), how will webpack serve get affected?
There was a problem hiding this comment.
When we use webpack server we use memory memory fs so install packages will not work
There was a problem hiding this comment.
but this is unused for some reason 🤔
There was a problem hiding this comment.
Because we don't have test with webpack-dev-server, we need to add them
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
NA
Summary
we were registering plugin twice in some precompile logic which was redundant.
Does this PR introduce a breaking change?
no
Other information