fix(index): update to allow requesting failed async css files #292
Conversation
|
|
cwalten
force-pushed
the
master
branch
2 times, most recently
from
ff3cf0a to
c3bec42
Compare
|
Okay, thanks for the input. I am working on tests now. I am also having trouble lining up my github account to the CLA form. I have signed it, but my initial commit was linked to a different account accidentally. I have overwritten the commitor and author fields but it is not triggering as expected. I will be working on fixing that after testing. Edit: added a manual test for this scenario that fails on current master but passes on my fork. Also due to that commit was seemingly able to reset the CLA bot. |
|
the failed test is also failing in master here |
|
@evilebottnawi @cwalten Any updates regarding the status of this PR? I would like to start consuming these changes when possible. |
|
/cc @ooflorent @sokra |
|
Just for the record, I replaced my mini-css-extract-plugin dependency with cwalten's master and it solved the problem. I can now retry loading CSS files just like it's done with JS files. 👍 |
This PR contains a:
Motivation / Use-Case
Related to #278
Since a rejected promise is left in installedCssChunks on a failed async import, the code to add the HTML link tag again is totally skipped.
Further, the code which has been removed in this PR is currently causing dynamically imported CSS files which have failed (but still have the link/ style tag added in the DOM) to simply return a resolve() instead of retrying the request. If we return resolve() simply because the link tag is in the DOM, the request is never retried and, though the Promise resolves correctly, the CSS is not loaded into the page.
Breaking Changes
Yes, as loading behavior of dynamically imported CSS files has been updated. Previous implementations might have been relying on the old functionality, which did not allow for retry scenarios.
Additional Info
These changes are modeled off of the async jsonp template code from webpack found here, where they do not do these duplication checks and reset the chunk key in the installedChunks object when the request fails.