-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable type attribute (#366) #367
Conversation
Add -loader suffix to reflect new loader syntax webpack 2 requirement
* Change position of 'Install' section. * Add --save-dev to install script
Update README.md
To allow inclusion in https://webpack.js.org/ docs.
Update the link to css-loader local scope
Extracted common config code to utils.js Added travis config Added mocha as devDep Added yarn.lock. Travis CI installs yarn if the file is present. Marked yarn.lock as binary to prevent conflict hell Moved web pack back from peerDep to dep Destructuring is not supported in Node v4.3, so replaced it Node v4 requires "use strict" to allow block scoped let & const Node v4: replaced "spread" operator with "apply"
Although the rel element is set to stylesheet the created link element does not specify the MIME type of the linked resource. The MIME type is set to text/css similar to the case when an style element is created. This change also syncs with the addStylesUrl.js behavior where the type attribute is set.
* Add ability to set custom attributes for tag in url mode
- Leverages a global npm lib in the container to check Webpack dist-tag versions
* feat: enable tag type configuration * feat: enable tag type configuration -- added tests
Usage section was rendering as "Usage Usage" class="icon-link" href="#usage">", removed the link, to make it consistent with source and rendering for css-loader for example.
José Moreira, Felix Mosheev seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Sorry for not setting the right user at first. I am the same user 😿 |
@ovidijusr need fix it, do force push with right username |
Link to issue:
#366 (comment)