Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable type attribute (#366) #367

Closed
wants to merge 106 commits into from
Closed

Add ability to disable type attribute (#366) #367

wants to merge 106 commits into from

Conversation

ovidijusr
Copy link

Link to issue:
#366 (comment)

kevinzwhuang and others added 30 commits November 16, 2016 10:46
Add -loader suffix to reflect new loader syntax webpack 2 requirement
* Change position of 'Install' section.
* Add --save-dev to install script
To allow inclusion in https://webpack.js.org/ docs.
Update the link to css-loader local scope
Extracted common config code to utils.js
Added travis config
Added mocha as devDep

Added yarn.lock. Travis CI installs yarn if the file is present.

Marked yarn.lock as binary to prevent conflict hell
Moved web pack back from peerDep to dep
Destructuring is not supported in Node v4.3, so replaced it

Node v4 requires "use strict" to allow block scoped let & const
Node v4: replaced "spread" operator with "apply"
Although the rel element is set to stylesheet the created link element does not specify the MIME type of the linked resource.
The MIME type is set to text/css similar to the case when an style element is created. This change also syncs with the addStylesUrl.js behavior where the type attribute is set.
* Add ability to set custom attributes for tag in url mode
michael-ciniawsky and others added 22 commits March 9, 2018 12:39
 - Leverages a global npm lib in the container to check Webpack dist-tag versions
* feat: enable tag type configuration

* feat: enable tag type configuration -- added tests
Usage section was rendering as "Usage Usage" class="icon-link" href="#usage">", removed the link, to make it consistent with source and rendering for css-loader for example.
@jsf-clabot
Copy link

jsf-clabot commented Feb 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 19 committers have signed the CLA.

✅ sokra
✅ SpaceK33z
✅ d3viant0ne
✅ simon04
✅ ekulabuhov
✅ ryani33
✅ sontek
✅ mistadikay
✅ dimitarivanov
✅ ahstro
✅ KonstantinKai
❌ kevinzwhuang
❌ johnjacobkenny
❌ blainekasten
❌ joeshub
❌ José Moreira
❌ Felix Mosheev
❌ FlyingDR
❌ tomasAlabes


José Moreira, Felix Mosheev seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@ovidijusr
Copy link
Author

Sorry for not setting the right user at first. I am the same user 😿

@alexander-akait
Copy link
Member

@ovidijusr need fix it, do force push with right username

@ovidijusr ovidijusr closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.