Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: security update for terser-webpack-plugin-legacy #330

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

antonku
Copy link

@antonku antonku commented Oct 8, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Hi. I assume that terser-webpack-plugin-legacy is unsupported taking into account that the notice regarding it is no longer in the readme. Still, is there any chance that you could publish a security update for it? Thanks.

This PR fixes: CVE-2019-16769 and CVE-2020-7660

@jsf-clabot
Copy link

jsf-clabot commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@alexander-akait alexander-akait merged commit 5ed0d20 into webpack-contrib:webpack-3 Oct 8, 2020
@alexander-akait
Copy link
Member

Released (1.2.4), my strong recommendation to migrate on webpack 4 or webpack 5 (recommended)

@antonku
Copy link
Author

antonku commented Oct 8, 2020

@evilebottnawi Thank you so much, you saved the day!

One more thing, I have noticed that in 1.2.4 there are several core-js require statements in dist/index.js and dist/minify.js, specifically:

require("core-js/modules/es7.object.get-own-property-descriptors");

require("core-js/modules/es6.object.to-string");

These imports may be a breaking change for consumers that don't have core-js@2.
Is it an intended change?

@alexander-akait
Copy link
Member

Yes, we need it because we support old Node.js versions, but maybe we can improve it, feel free to send a PR

@antonku
Copy link
Author

antonku commented Oct 8, 2020

Yes, we need it because we support old Node.js versions, but maybe we can improve it, feel free to send a PR

Got it, thanks. I think it makes sense to add core-js@2 to dependencies of terser-webpack-plugin-legacy so that end users without core-js@2 wouldn't experience issues during terser-webpack-plugin-legacy update.

I have opened a PR for it, please take a look: #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants