Apply suggestions from code review

Co-Authored-By: Yuriy Grunin <[email protected]>
webpack-contrib · Oct 11, 2019 · b4a48f3 · b4a48f3
1 parent 8065918
commit b4a48f3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/client/components/ModulesTreemap.jsx b/client/components/ModulesTreemap.jsx
@@ -209,7 +209,7 @@ export default class ModulesTreemap extends Component {
   handleConcatenatedModulesContentToggle = flag => {
     store.showConcatenatedModulesContent = flag;
     if (flag) {
-      localStorage.setItem('showConcatenatedModulesContent', '1');
+      localStorage.setItem('showConcatenatedModulesContent', true);
     } else {
       localStorage.removeItem('showConcatenatedModulesContent');
     }

diff --git a/client/store.js b/client/store.js
@@ -10,7 +10,7 @@ export class Store {
   @observable searchQuery = '';
   @observable defaultSize;
   @observable selectedSize;
-  @observable showConcatenatedModulesContent = localStorage.getItem('showConcatenatedModulesContent') === '1';
+  @observable showConcatenatedModulesContent = (localStorage.getItem('showConcatenatedModulesContent') === true);
 
   setModules(modules) {
     walkModules(modules, module => {

diff --git a/client/utils.js b/client/utils.js
@@ -28,16 +28,16 @@ export const localStorage = {
     }
   },
 
-  setItem(k, v) {
+  setItem(key, value) {
     try {
-      window.localStorage.setItem(k, v);
-    } catch (x) { /* ignored */ }
+      window.localStorage.setItem(`${KEY_PREFIX}.${key}`, JSON.stringify(value));
+    } catch (err) { /* ignored */ }
   },
 
-  removeItem(k) {
+  removeItem(key) {
     try {
-      window.localStorage.removeItem(k);
-    } catch (x) { /* ignored */ }
+      window.localStorage.removeItem(key);
+    } catch (err) { /* ignored */ }
   }
 
-};
+};