Improved readability: fixed serif font and tooltip opacity #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, seems like good changes to me! Can you sign the CLA please? Otherwise we are not allowed to merge your PR |
I did. If I click the link again (or the "Details" one next to the checks) it says "You have signed the CLA for webpack-contrib/webpack-bundle-analyzer", and it doesn't let me do again, the form at the bottom is disabled. |
|
Thanks for letting me know — seems like the CLA check had syncing issues. Closing and reopening the PR did the trick |
th0r
approved these changes
Oct 10, 2019
|
Released in v3.6.0 |
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system there's no
Verdanafont, therefore sidebar and tooltips are displayed with the ugly default serif font. I added an explicitsans-seriffallback for the--main-fontCSS variable, to make the system use the non-serif default font, at least.I also increased the opacity of tooltips to make them more readable against background text.
Here's a before / after: