Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

exit code is always 0 #31

Closed
1 of 3 tasks
MrMamen opened this issue Jun 12, 2018 · 5 comments · Fixed by #35
Closed
1 of 3 tasks

exit code is always 0 #31

MrMamen opened this issue Jun 12, 2018 · 5 comments · Fixed by #35

Comments

@MrMamen
Copy link

MrMamen commented Jun 12, 2018

  • Operating System: Ubuntu 18.04
  • Node Version: v8.10.0
  • NPM Version: 6.0.0
  • webpack Version: 4.9.1
  • webpack-command Version: 0.2.0

This issue is for a:

  • bug
  • feature request
  • modification request

Expected Behavior

If any errors occurs I expect some exit code > 0.

Actual Behavior

exit code is 0

How Do We Reproduce?

put some invalid code before running webpack

New Feature Use Case

@shellscape
Copy link
Contributor

@MrMamen Please do not remove portions of an issue template, or your issue will be marked as invalid and closed in the future. Please also make an effort in the future to provide a complete issue:

put some invalid code before running webpack

That helps no one understand your issue, as it lacks any context for which you might be seeing the issue. You also didn't provide any code; a webpack config and/or code which is generating an error for which you expect to see a different exit code.

@MrMamen
Copy link
Author

MrMamen commented Jun 26, 2018

This is the simplest example I can find. The only thing I did was creating an empty directory before running webpack-command with no config files or parameters:

$ ../../node_modules/.bin/webpack
ℹ 「webpack」: Starting Build
ℹ 「webpack」: Build Finished

webpack v4.9.1

44224b95b411030deb1a
size name module status

Δt 44ms

Entry module not found: Error: Can't resolve './src' in '/home/mrmamen/development/test'
0:0 error webpack-stylish:

configuration
0:0 warning The 'mode' option has not been set, webpack will fallback to
'production' for this value. Set 'mode' option to 'development' or
'production' to enable defaults for each environment.

✖ 2 problems (1 error, 1 warning)

The exit code is 0. This is revealed by entering echo $? (This is version 0.3.0, released after this issue was opened)

@shellscape
Copy link
Contributor

@MrMamen thanks. we released a new version with a fix for this.

@MrMamen
Copy link
Author

MrMamen commented Jun 26, 2018

@shellscape OK I'll have another look when v0.3.1 or v0.4.0 is public

@MrMamen
Copy link
Author

MrMamen commented Jul 5, 2018

The error still occurs on v0.3.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants