This repository has been archived by the owner on Sep 11, 2018. It is now read-only.
fix: exitCodes, reporters and bail, better error logging #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Jul 5, 2018
|
Thanks for covering the This PR also might fix -#31 |
ooflorent
suggested changes
Jul 6, 2018
lib/compiler.js
Outdated
| @@ -29,6 +35,10 @@ function makeCallback(options) { | |||
| if (error) { | |||
| reject(error); | |||
| return; | |||
| } else if (stats && stats.hasErrors() && !watch) { | |||
| process.exitCode = getErrorCount(stats); | |||
There was a problem hiding this comment.
Please use 1 instead. Using the error count as the exit code when prevent us from using meaningful non-zero exit codes.
There was a problem hiding this comment.
alexander-akait
approved these changes
Jul 6, 2018
ooflorent
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
It's been reported that #35 didn't do enough to address exit codes in the event of a build failure or error. During discovery, it was also found that the
--bailflag will cause errors in the reporters as well, as they were not anticipatingstatsbeingundefinedin the event that--bailwas used.Additionally, the logic for how an error is displayed when one occurs at the program level (outside of reporters) has been improved greatly and gives users more options to display additional info.
Breaking Changes
None
Additional Info
/cc @ankurk91 @MrMamen