fix(index): use `emit` hook instead of `this-compilation` #8

eseliger · 2018-02-18T00:47:00Z

`Issues`

`Notable Changes`

Made the change, as discussed in #7

jsf-clabot · 2018-02-18T00:47:01Z

All committers have signed the CLA.

eseliger · 2018-02-18T00:53:41Z

the build is failing unrelated to the changes (nsp warning)

michael-ciniawsky

@eseliger Thx

michael-ciniawsky · 2018-02-18T18:51:26Z

src/index.js

-            }
-          } else if (this.test && !this.test.test(file)) {
+    compiler.plugin('emit', (compilation, callback) => {
+      const { assets } = compilation;


michael-ciniawsky · 2018-02-18T18:51:44Z

src/index.js

-          let content = asset.source();
+        } else if (this.test && !this.test.test(file)) {
+          return cb();
+        }


michael-ciniawsky · 2018-02-18T18:54:51Z

src/index.js

-          this.algorithm(content, this.compressionOptions, (err, result) => {
-            if (err) { return cb(err); }
+        this.algorithm(content, this.compressionOptions, (err, result) => {
+          if (err) { return cb(err); }


Please don't 'inline' functions body's, whitespace is cheap :)

- if (err) { return cb(err); } + if (err) { + return cb(err); + }

michael-ciniawsky · 2018-02-18T18:55:17Z

src/index.js


-            let newFile = this.asset.replace(/\[(file|path|query)\]/g, (p0, p1) => sub[p1]);
+          let newFile = this.asset.replace(/\[(file|path|query)\]/g, (p0, p1) => sub[p1]);


newFile => newAsset

michael-ciniawsky · 2018-02-18T18:55:53Z

src/index.js

-            assets[newFile] = new RawSource(result);
+          if (typeof this.filename === 'function') {
+            newFile = this.filename(newFile);
+          }


michael-ciniawsky · 2018-02-18T18:56:03Z

src/index.js


-            let newFile = this.asset.replace(/\[(file|path|query)\]/g, (p0, p1) => sub[p1]);
+          let newFile = this.asset.replace(/\[(file|path|query)\]/g, (p0, p1) => sub[p1]);


eseliger · 2018-02-21T12:37:09Z

@michael-ciniawsky I can change the style, if you want, but I didn't change it, i just indented these rows, thats why they are in the diff. It was like that before.
Let me know what you think

michael-ciniawsky · 2018-02-21T19:32:09Z

Updating them would be appreciated :)

codecov · 2018-02-22T01:15:00Z

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff         @@
##           master   #8   +/-   ##
===================================
  Coverage       0%   0%           
===================================
  Files           2    2           
  Lines          51   51           
  Branches       26   26           
===================================
  Misses         33   33           
  Partials       18   18

Impacted Files	Coverage Δ
src/index.js	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced262b...a1caa02. Read the comment docs.

eseliger · 2018-02-22T01:15:18Z

@michael-ciniawsky updated the style, let me know if I missed something! :)

eseliger · 2018-02-25T15:19:48Z

is there anything I can do to bring this forward? :)

michael-ciniawsky

@eseliger Thx

eseliger · 2018-02-25T22:32:39Z

All the time! Let me know when you'll release it on npm

michael-ciniawsky · 2018-02-25T22:38:59Z

Unfortunately I realised that I don't have npm publish access to this repo (yet) atm. Which hopefully will be fixed within the next 1-2 days or someone else cuts a release (I pinged folks already :)). We will release it asap whenever possible

eseliger · 2018-02-25T22:40:05Z

Okay, awesome!

Kaesebrot84 · 2018-03-06T11:51:50Z

@michael-ciniawsky Any news?

fabioscsilva · 2018-05-14T14:21:07Z

@michael-ciniawsky @eseliger Any update? This is a great improvement that we are waiting for.

Use emit plugin api instead of this-compilation

4f68b05

michael-ciniawsky changed the title ~~Use emit plugin api instead of this-compilation~~ fix(index): use emit hook instead of this-compilation Feb 18, 2018

michael-ciniawsky added type: Bug priority: 3 (required) severity: 3 (broken) pr_action: Review status: Pending semver: Patch labels Feb 18, 2018

michael-ciniawsky requested review from alexander-akait, michael-ciniawsky and joshwiens February 18, 2018 18:50

michael-ciniawsky approved these changes Feb 18, 2018

View reviewed changes

michael-ciniawsky added this to the 0.1.1 milestone Feb 18, 2018

alexander-akait approved these changes Feb 21, 2018

View reviewed changes

fix: adjust codestyle

a1caa02

michael-ciniawsky approved these changes Feb 25, 2018

View reviewed changes

michael-ciniawsky added status: Approved and removed pr_action: Review priority: 3 (required) severity: 3 (broken) status: Pending labels Feb 25, 2018

michael-ciniawsky merged commit 45e7adb into webpack-contrib:master Feb 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(index): use `emit` hook instead of `this-compilation` #8

fix(index): use `emit` hook instead of `this-compilation` #8

eseliger commented Feb 18, 2018 •

edited by michael-ciniawsky

Loading

jsf-clabot commented Feb 18, 2018 •

edited

Loading

eseliger commented Feb 18, 2018

michael-ciniawsky left a comment

michael-ciniawsky Feb 18, 2018

michael-ciniawsky Feb 18, 2018

michael-ciniawsky Feb 18, 2018

michael-ciniawsky Feb 18, 2018

michael-ciniawsky Feb 18, 2018

michael-ciniawsky Feb 18, 2018

eseliger commented Feb 21, 2018

michael-ciniawsky commented Feb 21, 2018

codecov bot commented Feb 22, 2018

eseliger commented Feb 22, 2018

eseliger commented Feb 25, 2018

michael-ciniawsky left a comment

eseliger commented Feb 25, 2018

michael-ciniawsky commented Feb 25, 2018 •

edited

Loading

eseliger commented Feb 25, 2018

Kaesebrot84 commented Mar 6, 2018

fabioscsilva commented May 14, 2018


		let newFile = this.asset.replace(/\[(file\|path\|query)\]/g, (p0, p1) => sub[p1]);
		let newFile = this.asset.replace(/\[(file\|path\|query)\]/g, (p0, p1) => sub[p1]);

fix(index): use emit hook instead of this-compilation #8

fix(index): use emit hook instead of this-compilation #8

Conversation

eseliger commented Feb 18, 2018 • edited by michael-ciniawsky Loading

Issues

Notable Changes

jsf-clabot commented Feb 18, 2018 • edited Loading

eseliger commented Feb 18, 2018

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

michael-ciniawsky Feb 18, 2018

Choose a reason for hiding this comment

eseliger commented Feb 21, 2018

michael-ciniawsky commented Feb 21, 2018

codecov bot commented Feb 22, 2018

Codecov Report

eseliger commented Feb 22, 2018

eseliger commented Feb 25, 2018

michael-ciniawsky left a comment

Choose a reason for hiding this comment

eseliger commented Feb 25, 2018

michael-ciniawsky commented Feb 25, 2018 • edited Loading

eseliger commented Feb 25, 2018

Kaesebrot84 commented Mar 6, 2018

fabioscsilva commented May 14, 2018

fix(index): use `emit` hook instead of `this-compilation` #8

fix(index): use `emit` hook instead of `this-compilation` #8

eseliger commented Feb 18, 2018 •

edited by michael-ciniawsky

Loading

`Issues`

`Notable Changes`

jsf-clabot commented Feb 18, 2018 •

edited

Loading

michael-ciniawsky commented Feb 25, 2018 •

edited

Loading