Support splitting of files and directories in getTimeInfoEntries #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the splitting of
getTimeInfoEntries
between files and directories.This supports both old and new functionality:
As a small note, the caching present in old mechanism is removed. From my investigation, it doesnt actually block out much computation (since we still need to do the map merging one recursion-level up). The caching also would not provide any benefit in the new mechanism, as we need to do the same number of map additions regardless.
Given these changes, we can incorporate into webpack by changing using the new map-passing pattern here. I have those changes all ready to go, and all webpack-side watching tests are passing with my linked version of these changes.
https://github.com/webpack/webpack/blob/c181294865dca01b28e6e316636fef5f2aad4eb6/lib/node/NodeWatchFileSystem.js#L81