cli(color): don't use color on non-tty (#452)

webpack · May 20, 2018 · e87fd7d · e87fd7d
1 parent 8c58d24
commit e87fd7d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 210 deletions.
diff --git a/bin/cli.js b/bin/cli.js
@@ -79,7 +79,9 @@ For more information, see https://webpack.js.org/api/cli/.`);
 			type: "boolean",
 			alias: "colors",
 			default: function supportsColor() {
-				return require("supports-color").supportsColor;
+				if (process.stdout.isTTY === true) {
+					return require("supports-color").supportsColor;
+				}
 			},
 			group: DISPLAY_GROUP,
 			describe: "Enables/Disables colors on the console"
@@ -321,7 +323,10 @@ For more information, see https://webpack.js.org/api/cli/.`);
 				}
 			});
 
-			if (typeof outputOptions.colors === "undefined")
+			if (
+				typeof outputOptions.colors === "undefined" &&
+				process.stdout.isTTY === true
+			)
 				outputOptions.colors = require("supports-color").stdout;
 
 			ifArg("sort-modules-by", function(value) {

diff --git a/bin/process-options.js b/bin/process-options.js