-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add a constants file which exports all constants throughout the application #772
Labels
Comments
Will do this after #781 goes through. |
anshumanv
added a commit
to anshumanv/webpack-cli
that referenced
this issue
Mar 21, 2019
moved all constants to a separate file for CLI scopre and imported from there. ISSUES CLOSED: webpack#772
anshumanv
added a commit
to anshumanv/webpack-cli
that referenced
this issue
Mar 21, 2019
Format all code using prettier, remove console.log ISSUES CLOSED: webpack#772
ematipico
pushed a commit
that referenced
this issue
Mar 23, 2019
* chore(cli): move constants to a separate file moved all constants to a separate file for CLI scopre and imported from there. ISSUES CLOSED: #772 * chore(cli): lint files, rm console.log Format all code using prettier, remove console.log ISSUES CLOSED: #772 * chore(cli): codacy fix codacy fix * chore(cli): split destructuring into multiple lines split constants destructuring to multiple lines in config-yargs * chore(cli): update var name, revert oc update var name, revert oc * chore(cli): moved constants to utils moved constants to utils directory
anshumanv
added a commit
to anshumanv/webpack-cli
that referenced
this issue
Mar 26, 2019
* chore(cli): move constants to a separate file moved all constants to a separate file for CLI scopre and imported from there. ISSUES CLOSED: webpack#772 * chore(cli): lint files, rm console.log Format all code using prettier, remove console.log ISSUES CLOSED: webpack#772 * chore(cli): codacy fix codacy fix * chore(cli): split destructuring into multiple lines split constants destructuring to multiple lines in config-yargs * chore(cli): update var name, revert oc update var name, revert oc * chore(cli): moved constants to utils moved constants to utils directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Discussion for a possible refactor
What is the current behavior?
We're using a bunch of constants throught the code (
webpack-cli/bin/cli.js
Line 21 in 62ab32d
webpack-cli/bin/config-yargs.js
Line 55 in 62ab32d
What is the expected behavior?
Single file which exports all constants which is imported whereever needed (a possible refactor).
If this is a feature request, what is motivation or use case for changing the behavior?
Not a feature request.
Please paste the results of
webpack-cli info
here, and mention other relevant information such as programming language.Will do a quick PR in case we agree to proceed with this. 😄
The text was updated successfully, but these errors were encountered: