fix(webpack-cli): verbose and stats verbose flag fixed (rebase) #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested changes
Apr 14, 2020
|
Oh, Ah. I forgot that. working on it... |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
| @@ -5,7 +5,9 @@ const logger = require('../utils/logger'); | |||
| */ | |||
| class StatsGroup extends GroupHelper { | |||
| static validOptions() { | |||
| return ['none', 'errors-only', 'minimal', 'normal', 'detailed', 'verbose', 'errors-warnings']; | |||
| let validArrayString = ['none', 'errors-only', 'minimal', 'normal', 'detailed', 'verbose', 'errors-warnings']; | |||
| let validArrayObject = [{ verbose: true }, { verbose: true, stats: 'verbose' }]; | |||
There was a problem hiding this comment.
Why we need it here? We don't support objects in webpack-cli
There was a problem hiding this comment.
I used that for tests. It deals with when a user provide --stats verbose --verbose both flags together.
There was a problem hiding this comment.
Put it in tests - you can sue mocking
alexander-akait
requested changes
Apr 15, 2020
| } | ||
| function descriptionGenerator(example, shortDesc, acceptedValue = []) { | ||
| return `\n\n Example: ${example}\n\n ${acceptedValue.length > 0 ? acceptedString(acceptedValue) : ''}\n\n${shortDesc}`; | ||
| } |
There was a problem hiding this comment.
It was fix, not a new feature, do not mix fixes and features, you need to do it in difference PRs
|
@aman29271 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bugfix request which closes #1443
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
Not Needed
Summary
Does this PR introduce a breaking change?
No
Other information