-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(init): init entry point fix when path is mentioned #886
Fix(init): init entry point fix when path is mentioned #886
Conversation
Changed the init-generator code to fix the entry point issue when the entry point was answered
…ethsaha/webpack-cli into bugfix/init-entry-point-fix
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this same as in the entry questions file? We’re doing a similar check there
@evenstensberg we are getting PS : I changed the |
Hi @anikethsaha, thanks for the PR :) #817 is already addressing some of the issues of the |
@misterdev that one looks good. Are you sure about the particular entry property issue #884 is addressing?. I need to test that but if you say that one is fine then we can go with that :) |
Yeah, it fixes the problem you reported about the custom entry point not set in the configuration :) |
@misterdev let's keep that then 👍 |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Not Required
Summary
fix #884
Refactored the
init-genereator.ts
to change theentry
options in the webpack config file to the one answered if the answer is not emptyDoes this PR introduce a breaking change?
NA
Other information
The
regex
can be improved to more efficient with something like this