Feature/yeoman generators #93

evenstensberg · 2017-03-21T08:18:13Z

Changes the structure to the init feature a bit. We’re now making the parser validate everything, as we can later run the inquirer prompt after running yeoman, reading from a json file. This will allow us to have a more fluid process and removes a lot of «trash» code. Disabled listing for now, as this is work in progress.

This is the groundwork for me to align my work with the AST transformations @pksjce is doing. We're further gonna integrate the prompting from yeoman and we expect to get a config object back from the generator we run.

Changes the structure to the init feature a bit. We’re now making the parser validate everything, as we can later run the inquirer prompt after running yeoman, reading from a json file. This will allow us to have a more fluid process and removes a lot of «trash» code. Disabled listing for now, as this is work in progress.

okonet · 2017-03-21T10:49:10Z

lib/parser/generators/index.js

+
+class WebpackGenerator extends Generator {
+	constructor(args, opts) {
+		super(args, opts);


No need for constructor in this case.

Yeoman needs it, and I'm passing something to it later

Makes it possible to make a inquirer prompt with a remote package.

okonet · 2017-03-29T14:46:32Z

lib/creator/generators/index.js

@@ -1,4 +1,5 @@
 const Generator = require('yeoman-generator');
+// eslint-disable-next-line


Why have you disabled the next line? AFAIK destructuring won't work in Node 4.x

okonet · 2017-03-30T09:12:43Z

.yo-rc.json

+      "webpack-addons-preact"
+    ]
+  }
+}


Please add a new line

this is deleted.

okonet · 2017-03-30T09:13:49Z

lib/creator/generators/index.js

+	inject() {}
+}
+
+module.exports = WebpackGenerator;


Why not export directly in the declaration at L5?

okonet · 2017-03-30T09:14:19Z

lib/creator/index.js

+* @returns { <Function|Error> } initTransform - Initializes the scaffold in yeoman
+*/
+
+module.exports = function creator(pkgPaths,opts) {


White space after ,

okonet · 2017-03-30T09:15:31Z

lib/creator/init-transform.js

+			//eslint-disable-next-line
+		} catch (e) {}
+	}
+	else if(!options) {


This else if isn't needed.

okonet · 2017-03-30T09:16:06Z

lib/creator/init-transform.js

+		} catch (e) {}
+	}
+	else if(!options) {
+		const env = yeoman.createEnv();


Can be extracted from here and L18

okonet · 2017-03-30T09:18:27Z

lib/inquirer-prompt.js

@@ -9,20 +9,20 @@ const chalk = require('chalk');
 * @param { Object } questions - questions to be prompted in RxJS format
 * @param { Object } config - Configuration passed from an addon to be included in
 * answers, later sent down to the parser
-* @returns { Function } Parser function that validates the answers, later transforming
+* @returns { Function } Creator function that validates the answers, later transforming
 * the answers to an webpack configuration
 */

 module.exports = function prompt(questions, config) {
 	inquirer.prompt(questions).ui.process
 	.reduce(function (newOpts, ans) {


function -> =>

okonet · 2017-03-30T09:19:43Z

lib/inquirer-prompt.js

@@ -9,20 +9,20 @@ const chalk = require('chalk');
 * @param { Object } questions - questions to be prompted in RxJS format
 * @param { Object } config - Configuration passed from an addon to be included in
 * answers, later sent down to the parser
-* @returns { Function } Parser function that validates the answers, later transforming
+* @returns { Function } Creator function that validates the answers, later transforming
 * the answers to an webpack configuration
 */

 module.exports = function prompt(questions, config) {
 	inquirer.prompt(questions).ui.process
 	.reduce(function (newOpts, ans) {
 		return attachAnswers(newOpts, ans);


Actually, function(newOpts, ans) {...} -> attachAnswers

okonet · 2017-03-30T09:20:23Z

lib/creator/validate-options.spec.js

@@ -2,7 +2,7 @@

 describe('validate-options', () => {
 	//eslint-disable-next-line
-	const {validateOptions} = require('../../__mocks__/parser/validate-options.mock');
+	const {validateOptions} = require('../../__mocks__/creator/validate-options.mock');


Still eslint-disabled. This won't work in Node 4.x

okonet · 2017-03-30T09:20:57Z

lib/initialize.js

@@ -17,7 +14,7 @@ const Rx = require('rx');

 module.exports = function initializeInquirer(pkg) {
 	if(pkg.length == 0) {


Should we check if pkg is Array? Otherwise this will be a run-time error.

Is default in yargs, in the future, when we're revamping the ui, perhaps.

okonet · 2017-03-30T09:21:15Z

lib/initialize.js

@@ -17,7 +14,7 @@ const Rx = require('rx');

 module.exports = function initializeInquirer(pkg) {
 	if(pkg.length == 0) {
-		return prompt(Rx.Observable.from(questions), initialConfig);
+		return creator();
 	}
 	else {


No need for this else here.

Old code now

Removes inquirer, we’re not using it explicitly anymore. Fixed some review mistakes.

evenstensberg · 2017-03-30T17:53:48Z

@okonet I've removed inquirer.prompt, can look on commit history if we need to use it again.

okonet

evenstensberg added 2 commits March 17, 2017 20:45

fix: remove unneeded code

e1164ce

okonet reviewed Mar 21, 2017

View reviewed changes

evenstensberg added 6 commits March 21, 2017 22:09

feat: Generate yeoman instance from a package

cc18385

Makes it possible to make a inquirer prompt with a remote package.

feat: try using webpack-chain for obj-creation

fd018e0

feat: get build ready for refactor

af84d42

fix: rename parser to creator

9182aef

fix: enable listing for lib library and fix issues

01d83e2

Merge master with dev branch

ec0514b

okonet suggested changes Mar 29, 2017

View reviewed changes

evenstensberg changed the title ~~[WIP] Feature/yeoman generators~~ Feature/yeoman generators Mar 29, 2017

fix: don't disable lint for destructuring

1207ad8

pksjce approved these changes Mar 30, 2017

View reviewed changes

okonet suggested changes Mar 30, 2017

View reviewed changes

fix: remove inquirer prompt and fix minor issues

c7cae5b

Removes inquirer, we’re not using it explicitly anymore. Fixed some review mistakes.

fix: remove destruct and local import in some tests

aec044a

okonet approved these changes Mar 31, 2017

View reviewed changes

evenstensberg merged commit 16b80a0 into master Mar 31, 2017

evenstensberg deleted the feature/yeoman-generators branch March 31, 2017 10:16

addyosmani mentioned this pull request Apr 5, 2017

Feature: Enabling better extensibility & framework tooling integration #101

Closed

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/yeoman generators #93

Feature/yeoman generators #93

evenstensberg commented Mar 21, 2017 •

edited

Loading

okonet Mar 21, 2017

evenstensberg Mar 21, 2017

okonet Mar 29, 2017

okonet Mar 30, 2017

evenstensberg Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

okonet Mar 30, 2017

evenstensberg Mar 30, 2017 •

edited

Loading

okonet Mar 30, 2017

evenstensberg Mar 30, 2017

evenstensberg commented Mar 30, 2017

okonet left a comment

		@@ -1,4 +1,5 @@
		const Generator = require('yeoman-generator');
		// eslint-disable-next-line

		@@ -17,7 +14,7 @@ const Rx = require('rx');

		module.exports = function initializeInquirer(pkg) {
		if(pkg.length == 0) {

Feature/yeoman generators #93

Feature/yeoman generators #93

Conversation

evenstensberg commented Mar 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg Mar 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Mar 30, 2017

okonet left a comment

Choose a reason for hiding this comment

evenstensberg commented Mar 21, 2017 •

edited

Loading

evenstensberg Mar 30, 2017 •

edited

Loading