-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor refactor to eliminate code redundancy #2120
Minor refactor to eliminate code redundancy #2120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 33 33
Lines 1265 1265
Branches 361 363 +2
=======================================
Hits 1188 1188
Misses 71 71
Partials 6 6
Continue to review full report at Codecov.
|
9a4fafb
to
4409feb
Compare
@jamesgeorge007 Good idea, but this may be unnecessary since |
Yes, I think it is better. |
Sorry, I misread it. I wanna wait for changing |
@jamesgeorge007 I suggest you remove the |
4409feb
to
be5beaa
Compare
Need fix problem with lint |
@evilebottnawi It seems that everything's fine now 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this change is needed. |
Just less code 😄 |
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
To eliminate redundanct code resulting in much concise code-base.
Breaking Changes
N/A
Additional Info
N/A