Add Prettier formatter for JS files #3109
Conversation
|
Preview is ready Built with commit 8212408 https://deploy-preview-3109--webpackjsorg-netlify.netlify.com |
|
lmk if that needs to be closed 😄 |
| { | ||
| "singleQuote": true, | ||
| "printWidth": 100 | ||
| } |
There was a problem hiding this comment.
I recommend use this too:
trailingComma: 'es5',
arrowParens: 'always',
- Less changes in review
- Use parens for consistently output
- Also i recommend don't use printWidth:
100with spaces, it can generate unreadable code
There was a problem hiding this comment.
Looks good! Better now than never haha. Also I agree with @evilebottnawi
|
@evilebottnawi @anshumanv @EugeneHlushko Ping @anshumanv I would like to include all your changes, let's do it after merging this one. |
|
WIll update 👍 |
|
What is the blockage here ? |
|
@montogeek Why prettier is blocked? @chenxsan I think we need focus on this after webpack@5 upgrading |
|
Sure, I can do it after the webpack v5 upgrade if @montogeek doesn't have time to continue it. |
|
There is no blocker at this moment, I will restart it instead, can do it soon :) |
|
@montogeek Hi, do you still have time doing this? Otherwise I can take care of it. |
|
Closed via #4518 |
Continues #2247