-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to configure all hash functions used #14306
Conversation
For maintainers only:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe where we pass hashFunction = "md4"
as argument better do it using object options, like:
{ hashFunction = "md4" }
We may need more arguments in the future, so some signatures will be very ugly, just idea
Yeah, I also thought about that, but there is also the issue about memory pressure when creating additional objects. |
d231df8
to
b3da09c
Compare
fix default hash function for HttpUriPlugin to sha512
b3da09c
to
4815710
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
I've created an issue to document this in webpack/webpack.js.org. |
fix default hash function for HttpUriPlugin to sha512
add xxhash64 hash function
use xxhash64 as future default
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
output.hashFunction
now supports"xxhash64"
as fast hashing algorithm