Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure all hash functions used #14306

Merged
merged 4 commits into from
Sep 24, 2021
Merged

allow to configure all hash functions used #14306

merged 4 commits into from
Sep 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 22, 2021

fix default hash function for HttpUriPlugin to sha512

add xxhash64 hash function

use xxhash64 as future default

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?

  • output.hashFunction now supports "xxhash64" as fast hashing algorithm

@webpack-bot
Copy link
Contributor

webpack-bot commented Sep 22, 2021

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe where we pass hashFunction = "md4" as argument better do it using object options, like:

{ hashFunction = "md4" }

We may need more arguments in the future, so some signatures will be very ugly, just idea

@sokra
Copy link
Member Author

sokra commented Sep 22, 2021

Maybe where we pass hashFunction = "md4" as argument better do it using object options, like:

{ hashFunction = "md4" }

We may need more arguments in the future, so some signatures will be very ugly, just idea

Yeah, I also thought about that, but there is also the issue about memory pressure when creating additional objects.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants