add chromeFlags, chromePath and --headless as default

- fixes schickling#146 pdf only works in headless mode - fixes schickling#184 Add chromePath and chromeFlags to ChromelessOptions
webpolis · Oct 5, 2017 · d9cfea6 · d9cfea6
1 parent 6fca427
commit d9cfea6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/api.ts b/src/api.ts
@@ -45,6 +45,7 @@ export default class Chromeless<T extends any> implements Promise<T> {
         closeTab: true,
         ...options.cdp,
       },
+      chromeFlags: ['--headless'],
     }
 
     const chrome = mergedOptions.remote

diff --git a/src/chrome/local.ts b/src/chrome/local.ts
@@ -38,6 +38,8 @@ export default class LocalChrome implements Chrome {
     this.chromeInstance = await launch({
       logLevel: this.options.debug ? 'info' : 'silent',
       port: this.options.cdp.port,
+      chromeFlags: this.options.chromeFlags,
+      chromePath: this.options.chromePath,
     })
     const target = await CDP.New({
       port: this.chromeInstance.port,

diff --git a/src/types.ts b/src/types.ts
@@ -50,6 +50,8 @@ export interface ChromelessOptions {
   launchChrome?: boolean // auto-launch chrome (local) `true`
   cdp?: CDPOptions
   remote?: RemoteOptions | boolean
+  chromeFlags?: Array<string> // ['--headless']
+  chromePath?: string
 }
 
 export interface Chrome {