Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide printing not adding page breaks in the right spots #97

Closed
IronhandedLayman opened this issue Mar 17, 2017 · 10 comments
Closed

Slide printing not adding page breaks in the right spots #97

IronhandedLayman opened this issue Mar 17, 2017 · 10 comments

Comments

@IronhandedLayman
Copy link

When I attempt to print slides from reveal-md (0.1.2) using PhantomJS (version 2.1.1), the slides will go into a .pdf, but the page breaks are all wrong (slides are being broken by the page breaks).

@webpro
Copy link
Owner

webpro commented Mar 17, 2017

Yes, we're waiting on a reveal.js release for this (it's fixed in reveal's master branch).

@zerkalica
Copy link

Still not fixed, may be some workaround?

@webpro
Copy link
Owner

webpro commented Apr 23, 2017

Maybe you can ask the reveal.js maintainer(s) to release the latest changes, that should fix this issue.

@zerkalica
Copy link

Ok, but i don't know which pr link. Can you link this issue with suitable reveal.js pr?

@webpro
Copy link
Owner

webpro commented Apr 23, 2017

Last time I looked, it was already in their master branch. Just not released yet.

@zerkalica
Copy link

I found some issues in reveal.js, but don't sure that they related to this problem:

hakimel/reveal.js#1648
hakimel/reveal.js#1804

@webpro
Copy link
Owner

webpro commented Apr 24, 2017

Please try the following (psuedo):

git clone reveal-md
cd reveal-md
npm install git://reveal.js#master
npm link

Then try reveal-md slides.md on your slides.

@deeuu
Copy link

deeuu commented May 1, 2017

Hi,

Printing is also no good for me. I tried the above but still no luck.

Note that print example instructions work fine.

Would you mind explaining the problem to me, please?

Thanks

@webpro
Copy link
Owner

webpro commented May 9, 2017

The required fix of Reveal.js has been released, just after my last comment. I've updated the dependency and this is released in v0.3.0. Please let me know if PDF output is better now.

@webpro webpro closed this as completed May 9, 2017
@zerkalica
Copy link

Yes, bug fixed for me. Page breaks in pdf works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants