Empty page after each slide when exporting PDF from 3.4.0 #1804

pkubowicz · 2017-01-24T07:07:50Z

To reproduce:

clone reveal.js
run npm install && npm start
export to PDF according to https://github.com/hakimel/reveal.js#pdf-export

Result: you have 4 pages instead of 2. There is an empty page after each slide.

You can also change index.html to

Reveal.initialize({
			pdfMaxPagesPerSlide: 1,

but this does not have any effect. I tried using every bundled theme, but this also does not change the number of pages.

For me the vanilla presentation from the official repository should export correctly as PDF.

The text was updated successfully, but these errors were encountered:

hakimel · 2017-01-24T14:33:12Z

This should be fixed in master. Can you give it a try and let me know if it works for you as well?

Pretty major bug, so I'll put out a new release once the fix is confirmed.

pkubowicz · 2017-01-24T15:31:48Z

I checked it also on my own presentation and the fix works fine. Thanks a lot!

hakimel · 2017-01-25T09:49:53Z

Thanks for checking but turns out that change broke PDF exports through command line tools :/ Reworked it to avoid adjusting the page height and breakpoints.

pkubowicz · 2017-02-09T06:51:13Z

@hakimel This issue is present again in master. Reproduces as before, so pdfMaxPagesPerSlide does not work. Also present in dev. See the git bisect log:

# bad: [1413cbc1a9344a6366c30fb0e83d5b6afc18f6d3] Merge pull request #1636 from traff/master
# good: [286b69b61f64bf47dd3ea710175aeb4de8288d9f] fix empty pages in pdf exports (closes #1804)
git bisect start 'HEAD' '286b69b61f64bf47dd3ea710175aeb4de8288d9f'
# bad: [9f8e4d5742df486cce577f6e0dbae666aabc4eb1] 3.4.1
git bisect bad 9f8e4d5742df486cce577f6e0dbae666aabc4eb1
# bad: [953d302f8b3c1a5dfc430f2e34b67a81bc35c9d2] adjust pdf margins instead of heights to fix #1804
git bisect bad 953d302f8b3c1a5dfc430f2e34b67a81bc35c9d2
# good: [d9dcff1503cb4e8043a2b434de3cc635914164cb] additional fix for empty pages in pdf exports #1804
git bisect good d9dcff1503cb4e8043a2b434de3cc635914164cb
# first bad commit: [953d302f8b3c1a5dfc430f2e34b67a81bc35c9d2] adjust pdf margins instead of heights to fix #1804

hakimel · 2017-04-03T12:48:01Z

Reopening.

I'm seeing the empty pages appear when printing in Chrome 59, but not 57. Have been pursuing a fix for a while but haven't found one that works for both in-browser and CLI printing yet.

* hakimel-gh/master: new phantom pdf export script that works with 3.4.0 hakimel#1815 updated pdf docs update readme re: pdf exports hakimel#1823 Update README.md to include block for pdf printing Update README.md 3.4.1 adjust pdf margins instead of heights to fix hakimel#1804 additional fix for empty pages in pdf exports hakimel#1804 fix empty pages in pdf exports (closes hakimel#1804) correct grunt option usage For a fragment: allow to show a separate note defined in it

hakimel · 2017-04-04T11:40:42Z

This should be fixed in a way that works for both in-browser and command line (phantom, wkpdf etc) printing now.

Give it a try when you get a chance.

+@Skyr

Skyr · 2017-04-04T20:14:55Z

Sorry, no luck - demo.html still results in 66 pages.
(tested with Chromium on Fedora 24 (56.0.2924.87))

hakimel · 2017-04-05T07:30:47Z

Thanks for checking. I forgot to mention the change I made is only available in the dev branch – did you test master or dev?

The latest version can be tested in the live demo too: http://lab.hakim.se/reveal-js/?print-pdf. Chrome 57 & 59 on OS X are working. I don't have access to 56 so wasn't able to test that.

Skyr · 2017-04-05T09:25:57Z

My fault - I only checked the master.
The live demo is working perfectly 👍

hakimel · 2017-04-05T11:48:38Z

Whew, thanks!

* resolves hakimel#1324 allow display property to be configured - allow display property apply to current slide to be configured * add 'npm build' script that launch grunt * Allow switching off preview links The data-preview-link=false tag can be used to switch off preview links * Support sass extension for custom themes * Shift `dependencies` to `devDependencies`. The `reveal.js` npm module is typically installed to access the CSS/JS assets for Reveal.js. For those that want to run the plugins, they would clone the whole repository. Hence, it doesn’t make sense to include those as `dependencies`, which will increase download times. Closes hakimel#1734. * Allow background images without protocols to have query hashes/parameters. Closes hakimel#1603. * hakimel#1770, resume playback for paused media. * hakimel#1770, fixed function name. * hakimel#1770, added second argument for setAttribute * hakimel#1770, set 'data-paused-by-reveal' attribute only for the media elements, which are not already in paused state. * support complex markdown support <textarea data-template> `some code` </textarea> * Remove 'history: true' from index.html Readme says the default is 'history: false', so it may be surprising for users - it's easy to miss the contradicting setting in index.html * wait for in-slide video/audio to load before playing, reuse same autoplay logic for slide backgrounds * prevent autoplaying backgrounds from playing if slide is hidden * fix race condition by updating backgrounds after slide visibility * works with video, defaults to (same as for images) * remove unused argument * make backgrounds (iframes) interactive when the foreground is empty * 2017 * merge info links in index * fix empty pages in pdf exports (closes hakimel#1804) * additional fix for empty pages in pdf exports hakimel#1804 * adjust pdf margins instead of heights to fix hakimel#1804 * typo * note about showNotes in PDF exports hakimel#1800 * fix markdown typo, update comment hakimel#1780 * recommend using textarea wrapper for inline markdown hakimel#1780 * make background videos work on ipad hakimel#1778 * improved fragment notes support hakimel#1636 * warning about cube/page being deprecated hakimel#1774 * adjust comment for display config value hakimel#1325 * added toggleHelp function this way a key can be given ability to toggleHelp on and off. Previously Reveal.showHelp could open the help screen, but no way to close it. * added override parameter to toggleHelp function * update deserialize regex to work with decimals * docs for hakimel#1816 and remove showHelp * phantom export throws error if reveal.js isn't present * fix overview rendering issues in latest chrome hakimel#1649 * allow configuration of which view slide number appears on - fixes hakimel#1791 * correct config name in README * note about deploying multiplex server with now hakimel#1830 * tweaks to showSlideNumber config hakimel#1833 * avoid npe on iframe postMessage * print-pdf using callback iso timer Use window.callPhantom icw page. onCallback to wait for pdf-ready event. From: http://stackoverflow.com/a/28925479/129269 * print-pdf layout slide contents to fit stretch elements layout() and thereby layoutSlideContents() is never invoked when isPrintingPdf() is true so stretch elements are not sized correctly. This is ensured now by invoking the layoutSlideContents from SetupPDF(). There seems no need to scale down like in other PR's is suggested. * Fix video background autoplay on iOS * add autoPlayMedia config option, overrides individual autoplay settings * allow fullscreen for background iframes * new cli and in-browser pdf printing compatible fix for hakimel#1804 * make pdf page height offset configurable * replace cdn.mathjax.org with cdnjs cdn.mathjax.org is shutting down: https://www.mathjax.org/cdn-shutting-down/ This changes the default MathJax URL in the math plugin, as well as references in README.md and test/examples/math.html * formatting * formatting * clarify meaning of getProgress() value * expose getPastSlideCount() via public API This can be used by plugins which are concerned with helping the presenter with their pace. * clarify getTotalSlides() returns the number of slides * add new getSlides() API This can be used by plugins which are concerned with helping the presenter with their pace. * Allow popup window access to Reveal API * extract time display code into new _displayTime() function This will allow us to reuse the display code for displaying an additional pacing timer. * use opacity for muted clock elements This allows us to use different colours for different timers, which will be useful when we add a pacing timer. * don't mute minutes when hours is unmuted * avoid deleting existing classes when muting time elements and make muting work for negative values * don't show negative signs inside minutes/seconds elements * round decreasing timers to mirror increasing timers * document clock and timer in speaker notes window * optionally display pacing advice based on slide timings Add an option to display advice on whether the current pace of the presentation is on track for the right timing (shown as green), and if not, whether the presenter should speed up (shown as red) or has the luxury of slowing down (blue). The pacing timer can be enabled by configuring by the `defaultTiming` parameter in the `Reveal` configuration block, which specifies the number of seconds per slide. 120 can be a reasonable rule of thumb. Timings can also be given per slide `<section>` by setting the `data-timing` attribute. Both values are in numbers of seconds. When the option is enabled, clicking on the timers will reset the timer to the beginning of the current slide, i.e. as if pacing was perfectly on track, not to zero as if the presentation had just begun. * minor tweak for hakimel#1564 * 3.5.0 * * updated big picture slide * added schema image * added deployment texts * * update big picture svg * adjusted big picture styles * moved authors and company slides to the end * * * added styles for codelistings * tweaked dockerfile * added kubernetes cheatsheet * moved tldr slide to end of presentation * * added version number to html source * added config file for CircleCI integration * added deploy.sh * * updated status badge * troubleshooting deploy script * * bugfix as suggested in https://goo.gl/W1XnSk * * changed circle badges in readme * finetuning deploy.sh * moved sha label to span inside presentation * * optimized Dockerfile to leverage docker caching * * added key ‘v’ to toggle display of GIT sha in upper right corner * * added PS_VERSION_NUMBER to big picture slide * shortened stateflow texts * * removed unneeded files * * added link to github project on tldr * * changed port for k8-service * wip * * finetuning deployment * debug * * editorial finetuning * * extended deploy script to update dyndns with public cluster ip address * * added shell scripts for starting and stopping the kubernetes (k8) cluster on GCP * moved it all to subfolder k8 * * huge commit. The best. No seriously, it’s way to big and it can easily serve as a bad example. * * added seniority * finetuning claims on last slide * controls are now hidden * * extended collaboration slide * * added samples for collaboration * * replaced slide bgnd by collage * * modified collage * swapped slide order * added notes * reduced size of leafs bgnd * * tweakd tldr slide * * replaced the bgnd image on the collaboration slide - new one has some effects applied * * ignoring .vscode folder * * added data-timing values for every slide * extended readme section of the repo * * changed the way how the schema image is built into the slide * * windows millenium. and why you may never have heard of it

nickjmeyer · 2017-08-06T18:33:02Z

I'm having this same issue, except it seems slightly different. Instead of having a single blank page after each slide, the amount of blank space below each slide seems to be increasing exponentially. I have a ~45 slide deck and using ?print-pdf I get a ~46k page document.

I have yet to narrow down my html file to see what is causing it. Will do this next weekend if no one has jumped on it before me.

hakimel added a commit that referenced this issue Jan 24, 2017

additional fix for empty pages in pdf exports #1804

934c2e9

hakimel closed this as completed in 286b69b Jan 24, 2017

hakimel added a commit that referenced this issue Jan 24, 2017

additional fix for empty pages in pdf exports #1804

d9dcff1

hakimel added a commit that referenced this issue Jan 25, 2017

adjust pdf margins instead of heights to fix #1804

84202fa

hakimel added a commit that referenced this issue Jan 25, 2017

adjust pdf margins instead of heights to fix #1804

953d302

hakimel reopened this Apr 3, 2017

hakimel mentioned this issue Apr 3, 2017

Printing: Every second page empty #1862

Closed

hakimel added a commit that referenced this issue Apr 4, 2017

new cli and in-browser pdf printing compatible fix for #1804

2584a6d

SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017

fix empty pages in pdf exports (closes hakimel#1804)

85ad090

SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017

additional fix for empty pages in pdf exports hakimel#1804

787bd2f

SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017

adjust pdf margins instead of heights to fix hakimel#1804

ba83963

zerkalica mentioned this issue Apr 24, 2017

Slide printing not adding page breaks in the right spots webpro/reveal-md#97

Closed

hakimel closed this as completed in d4133f0 Apr 26, 2017

bnjmnt4n added the bug label Apr 27, 2017

derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018

fix empty pages in pdf exports (closes hakimel#1804)

07fc46d

derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018

additional fix for empty pages in pdf exports hakimel#1804

d59517c

derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018

adjust pdf margins instead of heights to fix hakimel#1804

102b333

derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018

new cli and in-browser pdf printing compatible fix for hakimel#1804

832ea44

R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021

fix empty pages in pdf exports (closes hakimel#1804)

282d3a1

R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021

additional fix for empty pages in pdf exports hakimel#1804

5c45d1a

R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021

adjust pdf margins instead of heights to fix hakimel#1804

f9f220d

R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021

new cli and in-browser pdf printing compatible fix for hakimel#1804

fa117c4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Empty page after each slide when exporting PDF from 3.4.0 #1804

Empty page after each slide when exporting PDF from 3.4.0 #1804

pkubowicz commented Jan 24, 2017

hakimel commented Jan 24, 2017

pkubowicz commented Jan 24, 2017

hakimel commented Jan 25, 2017

pkubowicz commented Feb 9, 2017 •

edited

Loading

hakimel commented Apr 3, 2017

hakimel commented Apr 4, 2017 •

edited

Loading

Skyr commented Apr 4, 2017

hakimel commented Apr 5, 2017

Skyr commented Apr 5, 2017 •

edited

Loading

hakimel commented Apr 5, 2017

nickjmeyer commented Aug 6, 2017

Empty page after each slide when exporting PDF from 3.4.0 #1804

Empty page after each slide when exporting PDF from 3.4.0 #1804

Comments

pkubowicz commented Jan 24, 2017

hakimel commented Jan 24, 2017

pkubowicz commented Jan 24, 2017

hakimel commented Jan 25, 2017

pkubowicz commented Feb 9, 2017 • edited Loading

hakimel commented Apr 3, 2017

hakimel commented Apr 4, 2017 • edited Loading

Skyr commented Apr 4, 2017

hakimel commented Apr 5, 2017

Skyr commented Apr 5, 2017 • edited Loading

hakimel commented Apr 5, 2017

nickjmeyer commented Aug 6, 2017

pkubowicz commented Feb 9, 2017 •

edited

Loading

hakimel commented Apr 4, 2017 •

edited

Loading

Skyr commented Apr 5, 2017 •

edited

Loading