WIP fix build vs serve

[nuke-web3]

Closes #370

still not quite there, help would be aprreciated!

[MartenBE]

Do you need any help with this?

[MartenBE]

I've tried it out and only changing the following fixed my use case (theme is selected for both the listings page as the slides):

module.exports.getThemeUrl = (theme, base = '') => {
  const parsedUrl = url.parse(theme);
  if (parsedUrl.host) {
    return theme;
  } else {
    const revealTheme = revealThemes.find(
      themePath => path.basename(themePath).replace(path.extname(themePath), '') === theme
    );
    return base + '/' + (revealTheme ? revealTheme : getAssetPath(theme)); // CHANGED ONLY THIS LINE
  }
};

This is the only line I changed from the npm package. @webpro , would this be a valid fix? This is currently the only bug to stop using this at our educational institution. This should at least fix #439 , however I am not certain what revealTheme does, the change probably wouldn't affect it.

[nuke-web3]

Do you need any help with this?

Sure - happy to have you replace this PR with another that include a patch and see if that fixes my issues as well 😀 - we are using this patch at an educational program in production, would be great to see what you are up too as well @MartenBE

[MartenBE]

I've submitted #458 , please try it out. It solves my error (but it is a small use case).