Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page-reuse concurrency + Browser Repair + Screencaster Cleanup Improvements #157

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Page-reuse concurrency + Browser Repair + Screencaster Cleanup Improvements #157

merged 5 commits into from
Aug 19, 2022

Conversation

ikreymer
Copy link
Member

Various improvements to opening multiple windows + recovering from errors, likely fix for #156, which was occurring more generally:

  • Call CDP command to open a window specifically in new window, avoid creating separate window and using window.open. Ensure window is always created
  • Repair capability: if CDP new window creation fails, likely something wrong, repair browser session by recreating browser in puppeteer. Mark existing pages as invalid
  • Page reuse flexibility: Instead of always reusing existing pages, have a max reuse number (25 page by default), also don't reuse pages if browser is repaired, or page load failure occurs (eg. cdp connection error), but not a regular timeout.
  • Screencaster cleanup: when a page fails, or browser is repaired, cleanup all cached targets in screencaster, to avoid sending stale data.
  • Rename NewWindowPage -> ReuseWindowConcurrency and move to windowconcur.js
  • bump to 0.7.0-beta.3

@ikreymer
new window: use cdp instead of window.open
0624091
@ikreymer
new window tweaks: add reuseCount, use browser.target() instead of op…
d351d1b 
…ening a new blank page
@ikreymer
rename NewWindowPage -> ReuseWindowConcurrency, move to windowconcur.js
fecd3fd 
potential fix for #156
@ikreymer
browser repair:
dce3596 
- when using window-concurrency, attempt to repair / relaunch browser if cdp errors occur
- mark pages as failed and don't reuse if page error or cdp errors occur
- screencaster: clear previous targets if screencasting when repairing browser
@ikreymer
bump version to 0.7.0-beta.3
d640d65
@ikreymer ikreymer merged commit 6cc38bf into main Aug 19, 2022
@ikreymer ikreymer deleted the window-context-tweaks branch August 19, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikreymer