Ignore hashtag on pages #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as WARC records do not contain hashtags
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 81.80% 81.87% +0.06%
==========================================
Files 4 4
Lines 676 673 -3
Branches 148 147 -1
==========================================
- Hits 553 551 -2
Misses 79 79
+ Partials 44 43 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tw4l
approved these changes
Jun 9, 2023
wacz/waczindexer.py
Outdated
| new_page = { | ||
| "timestamp": ts, | ||
| "url": input_page.get("url") or url, | ||
| "title": input_page.get("title") or url, |
There was a problem hiding this comment.
Curious what's the motivation to falling back to URL for the title if a title's not present, since we didn't before?
There was a problem hiding this comment.
It is actually doing that before, just a different way, first setting title as url and then overriding it. But agree that we should add tests for this..
- add test for hashtag in pages - allow extra fields to be passed in from provided pages.jsonl, instead of filtering only some fields - keep 'id' from provided pages.jsonl - keep other fields, such as 'loadState', from existing pages.jsonl
|
Added some tests, but also additional refactoring to be able to include additional fields in pages.jsonl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows matching of pages in a provided pages.jsonl to WARC records, ignoring the hashtag, eg.
https://example.com/#hashtagis matched to WARC recordhttps://example.com/. The page is added ashttps://example.com/#hashtagbut the timestamp of the record without the hashtag is used.bumps version 0.4.9