-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not overwrite Date with Memento-Datetime value #548
Comments
This is inaccurate. Memento-Datetime never overrides the Date header. The Date header is coming from the http response itself, you can verify it in the WARC. |
No, this is not inaccurate, unless I am failing to understand something here. I ran the following command a moment ago (you can try it too). The
|
And to make sure it is not something that our reverse proxy is mingling with, here is the output from a local instance in the default mode:
|
pywb is not adding the Date header, it is coming directly from the WARC record, eg. from example.com itself. Perhaps its confusing that its not prefixed with |
Now I got what you mean here. Though, the |
In my opinion, it is not an accurate interpretation of the semantics of the |
X-Archive-Orig-Date == Memento-Datetime Date is when the "the message was originated" https://tools.ietf.org/html/rfc7231#section-7.1.1.2 The "Date" header field represents the date and time at which the https://tools.ietf.org/html/rfc5322#section-3.6.1 The origination date specifies the date and time at which the creator If you make Date described the archived message, then you have no way to communicate the Date of the response from the archive. |
Considering some clock synchronization issues and network latency, it will more accurately be: X-Archive-Orig-Date ≈ Memento-Datetime And: Date > Memento-Datetime And in rare cases: Date ≈ Memento-Datetime |
- warcserver: when parsing headers to check for redirect, reserialized headers may be of different length then original, causing warcserver->app response to hang now adjusting the content-length on the warc record and also not including a fixed length when serving warcserver->app, possible fix for ukwa/ukwa-pywb#53 - undo change in path resolvers to use os.path.join, just concatenate full_path + filename - rewrite 'date' -> 'x-orig-archive-date' header to avoid confusion (eg. #548) - bump version to rc7
* misc fixes for 2.4.0rc7: - warcserver: when parsing headers to check for redirect, reserialized headers may be of different length then original, causing warcserver->app response to hang now adjusting the content-length on the warc record and also not including a fixed length when serving warcserver->app, possible fix for ukwa/ukwa-pywb#53 - undo change in path resolvers to use os.path.join, just concatenate full_path + filename - rewrite 'date' -> 'x-orig-archive-date' header to avoid confusion (eg. #548) - bump version to rc7 * ci: attempt to fix travis build for 27, 35
In main page mementos the value of the
Memento-Datetime
header overwrites theDate
header, these headers have distinct semantics, their valuesMUST NOT
be the same, except in rare cases when a memento is replayed within one second of its capture.See: https://ws-dl.blogspot.com/2020/03/2020-03-26-memento-compliance-audit-of.html#1-3-main-page-memento
The text was updated successfully, but these errors were encountered: