Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to re-write some URLs when replaying recent archives of http://www.bcg.com/ #676

Closed
anjackson opened this issue Nov 8, 2021 · 1 comment
Closed

Fails to re-write some URLs when replaying recent archives of http://www.bcg.com/ #676

anjackson opened this issue Nov 8, 2021 · 1 comment

Comments

@anjackson
Copy link
Contributor

Expected behavior

The page is https://www.bcg.com/ an when we replay it, we get content from our homepage inserted into it.

What actually happened

See ukwa/ukwa-pywb#70 - seems some dynamic content inclusion is slipping past Wombat?

Browser

Reproduced in various desktop browsers.
ikreymer added a commit that referenced this issue Nov 10, 2021
@ikreymer
rewriting fix: (fixes #676)
d943e84 
- don't rewrite 'data-' attributes
- do rewrite <link rel='alternate'> as main page (mp_)

escaping fix: don't escape URL in frame_insert.html, use as is

update to latest wombat (3.3.4)

bump to 2.6.1
@ikreymer
Copy link
Member

Caused by rewritten data- attributes.
Disabled rewriting of data- attributes, as accessing them via dataset property was not being handled in wombat.
Started to fix in wombat, but realized would be better to not rewrite them at all.
Fixed in 2.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anjackson @ikreymer