Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML metadata.yaml is escaped #727

Open
ArtHoff opened this issue Jun 17, 2022 · 1 comment
Open

HTML metadata.yaml is escaped #727

ArtHoff opened this issue Jun 17, 2022 · 1 comment

Comments

@ArtHoff
Copy link

ArtHoff commented Jun 17, 2022

Describe the bug

Hi
I upgraded from pywb 2.5.0 to the latest 2.6.7.
Since the upgrade my metadata does not display properly in the interface.
I have entries in my metadata.yaml files that create links, and they used to be displayed as links and were clickable.
Now, after the upgrade the links are displayed as text.
When looking at the page source I can see that the code is encoded. Instead of <a href="blah"> it now shows &lt;a href=&#34;blah&#34;&gt;

Steps to reproduce the bug

In the metadata.yaml file enter something like:
details: 'This site is being replaced by a new site: <a href="https://mysite.test.com/test">https://mysite.test.com/test</a>.'

Expected behavior

I expect to see clikcable links like this:
image

But I see this:
image

Environment

  • OS: RedHat Enterprise Linux Server release 7.9 (Maipo)
  • Browser Firefox, Chrome, Edge
  • Version not applicable

Additional context

tw4l added a commit to tw4l/pywb that referenced this issue Jul 29, 2022
tw4l added a commit to tw4l/pywb that referenced this issue Jul 29, 2022
tw4l added a commit to tw4l/pywb that referenced this issue Aug 3, 2022
tw4l added a commit to tw4l/pywb that referenced this issue Aug 3, 2022
ikreymer pushed a commit that referenced this issue Aug 3, 2022
@ArtHoff
Copy link
Author

ArtHoff commented Dec 12, 2022

Hi,
Thank you for addressing this issue, however there is still an issue with the HTML rewrite.
On the home page the first URL is clickable, but the one in the comment is displayed as HTML.
I expect to see:
Link

But instead it shows:
No link

Thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant