Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite inject fix: #516

Merged
merged 1 commit into from
Nov 7, 2019
Merged

rewrite inject fix: #516

merged 1 commit into from
Nov 7, 2019

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 7, 2019

Description

Instead of injecting _____WB$wombat$check$this$function_____() into ever script,
override at object prototype level (from webrecorder/wombat#19), to fix replay.
Update to latest wombat.js with additional improvements (webrecorder/wombat#18, webrecorder/wombat#19)

Motivation and Context

Fixes replay where the script is additionally transpiled, and the check this function
applied on a different object.
Fixes replay of https://public.zenkit.com/i/2RH604FcHf/KApaBfSU0vK/web-archiving-for-all-with-webrecorder?v=LK9b3laIX&hide=workspaceLists

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

…ed by wombat via prototype

update to latest wombat
@ikreymer ikreymer merged commit fe09d99 into develop Nov 7, 2019
@ikreymer ikreymer deleted the replay-fix branch November 7, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant