proxy mode: respect settings when started from cli #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is reasonable workaround for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you configure some proxy settings like enable_content_rewrite in config.yaml, when you run wayback --proxy mycollection it does not work.
This is because the entire proxy section is replaced by the extra config (custom_config) generated according to the command line arguments in cli.py.
This fix makes the section values to be replaced, but not the entire section. So the existing values won't be removed.
Another approach would be to add command line arguments for the rest of the available settings like --proxy-enable-content-rewrite, etc... I don't know which is preferred in this project.