Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode url search parameter when performing query #657

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Encode url search parameter when performing query #657

merged 1 commit into from
Jul 7, 2021

Conversation

maeb
Copy link
Contributor

@maeb maeb commented Jul 6, 2021

Description

Searching for URL's with semicolons fails because the url search paramater is not encoded in the request from the frontend to the backend. The backend receives the full URL but in the request to the CDXJ server the request is cutoff at (and including) the first semicolon.

Motivation and Context

#656

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer
Copy link
Member

ikreymer commented Jul 7, 2021

Thanks!

@ikreymer ikreymer merged commit 843fe28 into webrecorder:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants