Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternate fix to #663 that removes the
WB_wombat_
prefix and instead overrides non-top-level withself.eval
.The proxy in wombat.js intercepts
eval()
on the object and returns a version that has rewriting enabled.This is possible since:
and
are equivalent in that the eval is run in the global scope, but, the latter allows for interception of eval by the object proxy.
Also: wrapping injected
let
vars in separate anonymous scope, as suggested in webrecorder/wombat#72Motivation and Context
Provides a fix for #663 and avoids the false positive introduced in #664.
(Note: still small chance of issue if
self
is redefined, can revisit if real-world examples come up).Screenshots (if appropriate):
Types of changes
Checklist: