Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fbclid #691

Merged
merged 13 commits into from
Jan 26, 2022
Merged

Remove fbclid #691

merged 13 commits into from
Jan 26, 2022

Conversation

omgoo
Copy link
Contributor

@omgoo omgoo commented Jan 20, 2022

Description

Removes fbclid query stings.

Motivation and Context

We had an issue with UKGWA archive links been shared on Facebook. Facebook appends fbclid query strings to the urls and breaks replay.

Example URL: https://www.facebook.com/flx/warn/?u=https%3A%2F%2Fwebarchive.nationalarchives.gov.uk%2F20200923133623%2Fhttps%3A%2F%2Fstfc.ukri.org%2Fnews%2Fuk-supercomputers-simulate-impact-of-the-asteroid-thought-to-have-wiped-out-dinosaurs%2F%3Ffbclid%3DIwAR34X3SU0jtf-vq9Fm-GnOfnEqUxJaZXy6AOzcydijWSGS6T8JGIslI1GCs&h=AT1CpOAZVavckSYZXSdO0SUCPfog19bBRbT7j0BzlD8E7TLJXDCm0DK3OqpNwBJd0BUO_tQQqQzrB3i7d2ogxGywywhP6KyxUYY6rkyVW28jdepcCe3zeb1of2e-QtbJBQ-14sQ-BRVm1MEMSn24ecBQuyOHuRXqJ2MBre9ROt1l2rlnRB7IGkbNFRoI2ZVeYKc5jLSBbOei

The above link will soon be working as we deploy this fix to the UKGWA

Screenshots (if appropriate):

Types of changes

  • [ x] Replay fix

Checklist:

  • I'm unsure if this removal rule may be too aggressive. Do we see fbclid query strings anywhere other than at the end of a url pattern? Could there be legitimate archives with the fbclid query string in the warc url path?

@ikreymer
Copy link
Member

Thanks! Yeah, I think that's reasonable enough, I've seen fbclid as well from facebook, so this seems like a good compromise.

@ikreymer ikreymer merged commit 825e4e5 into webrecorder:main Jan 26, 2022
@omgoo omgoo deleted the remove-fbclid branch January 27, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants