Encoding image 'srcset' value including the intrinsic width #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
reviewed
Aug 1, 2022
| @@ -177,7 +177,7 @@ def _rewrite_srcset(self, value, mod=''): | |||
| return '' | |||
|
|
|||
| values = (url.strip() for url in re.split(self.SRCSET_REGEX, value) if url) | |||
| values = [self._rewrite_url(v.strip()) for v in values] | |||
| values = [self._rewrite_url(v.split(' ')[0].strip()) + (' ' + ' '.join(v.split(' ')[1:])).rstrip() for v in values if v] | |||
There was a problem hiding this comment.
It would be nice to see a comment here for what is going on here, and why it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the image attribute srcset value contains an unsupported character(https://www.rfc-editor.org/rfc/rfc3986#section-2) then the url will be encoded. In this case the value contains a space and the image intrinsic width which will cause a broken image after encoding.
Motivation and Context
This resolves the problem with encoding image url excluding the intrinsic width.
Types of changes
Checklist: