Activate field validation when expanding the advanced options #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an id tag to the advanced search options button and bind a lambda function to clicking on it in order to activate field validation when expanding the advanced options.
Motivation and Context
Having to click Search with an empty URL in order to get instructions about what format the from and to timestamps should be is not obvious. If you have already entered a URL there's no way to get feedback on entered values short of removing the URL and clicking Search.
It would make more sense to enable field validation as soon as the advanced options are expanded. (I'm guessing it is not enabled from start to avoid getting an error message on every new search.)
Screenshots (if appropriate):
Current behavior:
Expected behavior:
Types of changes
Checklist:
The
tests/test_auto_colls.py::TestManagedColls::test_add_static
test fails with or without this change but the other 807 tests pass.