Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate field validation when expanding the advanced options #722

Merged

Conversation

krakan
Copy link
Contributor

@krakan krakan commented May 18, 2022

Description

Add an id tag to the advanced search options button and bind a lambda function to clicking on it in order to activate field validation when expanding the advanced options.

Motivation and Context

Having to click Search with an empty URL in order to get instructions about what format the from and to timestamps should be is not obvious. If you have already entered a URL there's no way to get feedback on entered values short of removing the URL and clicking Search.
It would make more sense to enable field validation as soon as the advanced options are expanded. (I'm guessing it is not enabled from start to avoid getting an error message on every new search.)

Screenshots (if appropriate):

Current behavior:
2022-05-18-132616_1147x561_scrot
Expected behavior:
2022-05-18-132806_1137x590_scrot

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.
    The tests/test_auto_colls.py::TestManagedColls::test_add_static test fails with or without this change but the other 807 tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants