Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve replay banner's accessibility #742

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

lwrubel
Copy link
Contributor

@lwrubel lwrubel commented Jul 19, 2022

Description

  • Puts banner in header and nav landmark regions
  • Adds landmark role of banner to header

Motivation and Context

The SiteImprove automated accessibility checker flags the replay banner for not following ARIA Authoring Practices, specifically concerning landmark regions. These changes are intended to improve site navigation by screen readers.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

* Puts banner in header and nav landmark regions
* Adds landmark role of banner to header
@ikreymer ikreymer merged commit 49393ce into webrecorder:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants