Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite: detect edge-case where html starts with bom followed #758

Merged
merged 1 commit into from
Aug 31, 2022
Merged

rewrite: detect edge-case where html starts with bom followed #758

merged 1 commit into from
Aug 31, 2022

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Aug 31, 2022 •
edited
Loading

Description

Fix edge-case rewriting where HTML page starts with BOM followed by <!DOCTYPE html>.
Previously, was not detect as HTML.

Add new test for this.

Motivation and Context

Fixes #756

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer ikreymer merged commit 1249b41 into main Aug 31, 2022
@ikreymer ikreymer deleted the rewrite-ignore-bom-fix branch August 31, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No rewritig of <script type="text/javascript" src="http://code.jquery.com/jquery-1.6.3.min.js"></script>
1 participant
@ikreymer