Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

remove use of lazy_static #20

Merged
merged 1 commit into from
May 22, 2022
Merged

remove use of lazy_static #20

merged 1 commit into from
May 22, 2022

Conversation

oll3
Copy link
Contributor

@oll3 oll3 commented May 22, 2022

Seemed overkill to include lazy_static for a single, short lookup map. Hence replaced the implementation with a static array. Guessing its about the same performance wise, or faster, for short lists like these.

Replace with a static list of string values.
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #20 (3b23c96) into main (e4f16f4) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   46.25%   46.25%           
=======================================
  Files          75       75           
  Lines        8646     8646           
  Branches     1881     1885    +4     
=======================================
  Hits         3999     3999           
+ Misses       3513     3512    -1     
- Partials     1134     1135    +1     
Impacted Files Coverage Δ
src/conn/conn_test.rs 72.89% <0.00%> (ø)
src/lib.rs 19.69% <ø> (ø)
src/state.rs 69.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f16f4...3b23c96. Read the comment docs.

@rainliu rainliu merged commit 1bedb63 into webrtc-rs:main May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants