Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdns: Skip rest of mdns questions when parsing packet #511

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

haaspors
Copy link
Contributor

@haaspors haaspors commented Nov 9, 2023

This fixes the annoying warning when receiving a mdns packet with more than 3 questions

[2023-11-09T12:04:04Z WARN webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet [2023-11-09T12:04:08Z WARN webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet [2023-11-09T12:04:17Z WARN webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet

This fixes the annoying warning when receiving a mdns packet with more than 3 questions

[2023-11-09T12:04:04Z WARN  webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet
[2023-11-09T12:04:08Z WARN  webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet
[2023-11-09T12:04:17Z WARN  webrtc_mdns::conn] Failed to parse mDNS packet parsing/packing of this type isn't available yet
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13c490c) 61.59% compared to head (15f53a6) 61.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   61.59%   61.53%   -0.07%     
==========================================
  Files         529      529              
  Lines       48912    48865      -47     
  Branches    12365    12374       +9     
==========================================
- Hits        30129    30069      -60     
+ Misses       9601     9596       -5     
- Partials     9182     9200      +18     
Files Coverage Δ
mdns/src/conn/mod.rs 58.06% <100.00%> (+0.19%) ⬆️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit d751e94 into webrtc-rs:master Nov 11, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants