This repository has been archived by the owner on May 13, 2024. It is now read-only.
bandwidth test: PLI is picture loss indication #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not packet loss indication. See https://tools.ietf.org/html/rfc4585 Arguably, it is an indication for severe packet loss.
|
I also moved it closer to the NACK in the list. I doubt anyone will notice or care but... |
henbos
approved these changes
Sep 27, 2017
| @@ -270,8 +270,8 @@ VideoBandwidthTest.prototype = { | |||
| this.test.reportInfo('Packets sent: ' + this.packetsSent); | |||
| this.test.reportInfo('Packets received: ' + this.packetsReceived); | |||
| this.test.reportInfo('NACK count: ' + this.nackCount); | |||
| this.test.reportInfo('Picture loss indications: ' + this.pliCount); | |||
There was a problem hiding this comment.
Correct, I filed w3c/webrtc-stats#247
|
Thanks for spotting this. Also I intend to rewrite the stats handler in AppRTC and TestRTC but it's a mess..... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not packet loss indication. See https://tools.ietf.org/html/rfc4585
Arguably, it is an indication for severe packet loss.
@henbos I heard you know a bit about this "statistics" stuff, can you review?