Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Includes version.cjs in .npmignore #311

Merged
merged 1 commit into from
Jun 14, 2024
Merged

FIX: Includes version.cjs in .npmignore #311

merged 1 commit into from
Jun 14, 2024

Conversation

SilentBot1
Copy link
Member

@SilentBot1 SilentBot1 commented Jun 13, 2024

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR adds an exclusion to version.cjs in the .npmingore, which is currently excluding this file from the published package, preventing [email protected] from working whatsoever.

Following this change, npm pack generates a package with all the required files and works as expected:
image

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

…ublished package from functioning correctly.
@SilentBot1 SilentBot1 merged commit c3138e0 into master Jun 14, 2024
6 checks passed
@SilentBot1 SilentBot1 deleted the fix/npmignore branch June 14, 2024 11:08
webtorrent-bot pushed a commit that referenced this pull request Jun 14, 2024
## [5.1.2](v5.1.1...v5.1.2) (2024-06-14)

### Bug Fixes

* include version.cjs in the .npmignore, which is preventing the published package from functioning correctly. ([#311](#311)) ([c3138e0](c3138e0))
@webtorrent-bot
Copy link

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing 5.1.1 results in an error
3 participants