Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api changes of nightly zig installHeader #346

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

jinzhongjia
Copy link
Collaborator

@jinzhongjia jinzhongjia commented Apr 10, 2024

Build Api Changes

installHeader and LazyPath has changes, see these PR:
ziglang/zig#19167
ziglang/zig#19597

Note

Please do not merge this PR for now because it is not completed yet and I need to wait for an important PR from upstream
ziglang/zig#19597 to be merged before I can continue the implementation.

@jinzhongjia
Copy link
Collaborator Author

All right, everything is ok, can you approve this pr? @neroist
By the way, this PR is two days late due to my problem, I'm in the process of migrating my system to nixos

@jinzhongjia jinzhongjia marked this pull request as ready for review April 14, 2024 02:58
@jinzhongjia jinzhongjia requested a review from neroist April 14, 2024 02:58
@neroist neroist merged commit 32f876a into main Apr 14, 2024
22 checks passed
@jinzhongjia jinzhongjia deleted the build_api_change branch April 21, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants