Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log out a user from rocket chat when logging out #311

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

2e2a
Copy link

@2e2a 2e2a commented Apr 17, 2023

Implementations details:

  • Add a custom login script to rocket chat, that copies the session cookies setting the domain to the portals top-level domain. This makes the rocket chat session information available in the portal backend.
  • Use the rocket chat API to logout a user session using the session information from the cookies when logging out from the platform.

@2e2a 2e2a requested a review from saschasommer April 17, 2023 13:49
@saschasommer
Copy link
Contributor

Feature tested and code reviewed. Thank you!

@saschasommer saschasommer merged commit bf54225 into redesign Apr 18, 2023
@saschasommer saschasommer deleted the feature/rc-logout branch April 18, 2023 10:01
saschasommer added a commit that referenced this pull request Apr 18, 2023
Relay event messages to RocketChat (#310)
(https://git.wechange.de/wechange/aktuell/public-feature-pipeline/-/issues/11)

* Refactor note relay functionality to make it reusable.
  * Adding a utility model mixin defining functions to get the message, title and emote to be used in the relayed message. Added this mixin to a newly created cosinnus_message.mixins, not sure about this location.
  * Make use of the mixin functions in the note model and the rocket_chat message relay code.
* Add event message relaying
  * Implement the mixin in the event model.
  * Add a get_perdiod_with_time helper to get the event times.
  * Handle event changes in the relay hooks.
* Fix message truncation
  * Django's truncatewords filter striped all newlines. Probably not what we want.
  * Added a simple custom helper that does the truncation keeping linebreaks using regex.

---

Log out a user from rocket chat when logging out #311 
(https://git.wechange.de/wechange/aktuell/wechange/-/issues/1660)

* Add a custom login script to rocket chat, that copies the session cookies setting the domain to the portals top-level domain. This makes the rocket chat session information available in the portal backend.
* Use the rocket chat API to logout a user session using the session information from the cookies when logging out from the platform.
saschasommer added a commit that referenced this pull request Aug 9, 2024
* redesign #318: remove "Edit my Profile" personal menu entry

https://git.wechange.de/gl/code/redesign/-/issues/318

* redesign #321: move "set up my profile" button from menu to leftnav

https://git.wechange.de/gl/code/redesign/-/issues/321

* Adjust test_navigation_api tests for changed menu structure

* Also removed v2 profile menu buttons from #321 and #318 on v3 portals

* Redesign #322: Move "Change language" from user menu to profile leftnav

It appears only in v3 contexts and has the hardcoded id "ChangeLanguage"

https://git.wechange.de/gl/code/redesign/-/issues/322

* redesign #311: v3 main content: re-order group-area leftnav buttons

https://git.wechange.de/gl/code/redesign/-/issues/311

* v3 main navigation: add "Events" forum alongside forum

For portals that have a split Forum/Events group

* redesign #315: v3 navigation: Move "Discover" link

- no longer shown in main navbar services for logged in users
- still shown in main navbar services for anonymous in users
- now shown with correct icon in spaces community section

* v3 main menu: show Managed Tags Paired Groups by default

(was not showing Portalpartner Forums else)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants