-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSPP 2021: python puppet itchat #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the blog! Please change as request:
- I found you delete
assets/contributors/lyleshaw/avatar.png
but didn't addwebp
image for this PR, which will cause your profile to miss your avatar, please add this image. - As OSPP Guide required , you should change
jekyll/_posts/2021-07-13-summer-wechaty-itchat-puppet.md
tojekyll/_posts/2021-07-13-ospp-plan-your-fileaname
Done~ |
@lyleshaw Good job! Please invite your mentor to review this PR and approve this PR, then I will merge this~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change as I request, then I will merge this PR. Thanks.
- 实施方案: | ||
在该阶段,我计划将 Itchat 剩余的接口根据 Wechaty 的代码风格封装进 python-wechaty-puppet-itchat。 | ||
|
||
- *L5阶段: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is redundant *
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means L5 is optional~
Thank you very much for your contribution! You are welcome to join Wechaty Contributor Program1. Join Wechaty Organization
I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. 2. Update Your Wechaty Contributor Profile
3. Join The Contributor Only WeChat RoomWe also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested. Please add my wechat: ruirui_0914 and send me this pr link. I will invite you into Wechaty Contributor Room Link to wechaty/PMC#16 Cheers! |
Please make sure to check the following boxes creating your pull request, thank you very much!
Add Blog Header, including title, author, image, categories, tags, etc.
For example:
Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
Embed video/pdf from YouTube/Bilibili/local (if there's any) by using
{% include iframe.html src="URL_or_PATH" %}
. (Learn more about how to embed file/url in the post by reading this blog postSave photo to local before publishing, to a folder named by
${MONTH}-${YOUR_BLOG_SLUG}/
under/assets/2021/
directory.Select a beautiful and meaningful teaser image for your blog
Create your contributor profile (if you are a first time contributor)
For excample:
Here is the example file:
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/