Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPP 2021: python puppet itchat #1069

Merged
merged 11 commits into from
Jul 16, 2021
Merged

OSPP 2021: python puppet itchat #1069

merged 11 commits into from
Jul 16, 2021

Conversation

lyleshaw
Copy link
Member

@lyleshaw lyleshaw commented Jul 13, 2021

Please make sure to check the following boxes creating your pull request, thank you very much!

  • Add Blog Header, including title, author, image, categories, tags, etc.

    For example:

    ---
    title: Your Great Blog Title
    author: your_github_id
    categories: project
    tags:
      - python
      - padlocal
    image: /assets/2021/02-your-blog-slug/teaser.jpg
    ---
    
    One line bio
    
    Your blog post content Your blog post content
    Your blog post content Your blog post content
    Your blog post content Your blog post content

    It will be easier to start drafting your post by using a existing post file as your template, for example, this one

  • Keep all filenames lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor.md instead of 2017-10-06-WeChat PC Impactor.md

  • Embed video/pdf from YouTube/Bilibili/local (if there's any) by using {% include iframe.html src="URL_or_PATH" %}. (Learn more about how to embed file/url in the post by reading this blog post

  • Save photo to local before publishing, to a folder named by ${MONTH}-${YOUR_BLOG_SLUG}/ under /assets/2021/ directory.

  • Select a beautiful and meaningful teaser image for your blog

  • Create your contributor profile (if you are a first time contributor)

    For excample:

    jekyll/_contributors/lijiarui.md

    ---
    name: Jiarui LI (李佳芮)
    site: https://lijiarui.github.io
    bio: 句子互动创始人 & CEO,微软人工智能最具价值专家 (AI MVP)
    avatar: /jekyll/assets/contributors/lijiarui/avatar.png
    email: [email protected]
    twitter: https://weibo.com/u/2175505900
    ---

    Here is the example file:

To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/

@lyleshaw lyleshaw requested a review from a team as a code owner July 13, 2021 08:16
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the blog! Please change as request:

  1. I found you delete assets/contributors/lyleshaw/avatar.png but didn't add webp image for this PR, which will cause your profile to miss your avatar, please add this image.
  2. As OSPP Guide required , you should change jekyll/_posts/2021-07-13-summer-wechaty-itchat-puppet.md to jekyll/_posts/2021-07-13-ospp-plan-your-fileaname

@lyleshaw
Copy link
Member Author

Thanks for the blog! Please change as request:

  1. I found you delete assets/contributors/lyleshaw/avatar.png but didn't add webp image for this PR, which will cause your profile to miss your avatar, please add this image.
  2. As OSPP Guide required , you should change jekyll/_posts/2021-07-13-summer-wechaty-itchat-puppet.md to jekyll/_posts/2021-07-13-ospp-plan-your-fileaname

Done~

@lyleshaw lyleshaw requested a review from lijiarui July 14, 2021 07:29
@lijiarui
Copy link
Member

@lyleshaw Good job!

Please invite your mentor to review this PR and approve this PR, then I will merge this~

Copy link
Contributor

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change as I request, then I will merge this PR. Thanks.

- 实施方案:
在该阶段,我计划将 Itchat 剩余的接口根据 Wechaty 的代码风格封装进 python-wechaty-puppet-itchat。

- *L5阶段:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is redundant * here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means L5 is optional~

@lijiarui lijiarui merged commit 2c0a23b into wechaty:master Jul 16, 2021
@lijiarui
Copy link
Member

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited lyleshaw to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add my wechat: ruirui_0914 and send me this pr link. I will invite you into Wechaty Contributor Room

Link to wechaty/PMC#16

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants