Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPP 2021: Wechaty Lark Puppet #1085

Merged
merged 8 commits into from
Jul 27, 2021
Merged

Conversation

remember00000
Copy link
Contributor

@remember00000 remember00000 commented Jul 14, 2021

Please make sure to check the following boxes creating your pull request, thank you very much!

Add Blog Header, including title, author, image, categories, tags, etc.

For example:


title: Your Great Blog Title
author: your_github_id
categories: project
tags:

  • python
  • padlocal
    image: /assets/2021/02-your-blog-slug/teaser.jpg

One line bio

Your blog post content Your blog post content
Your blog post content Your blog post content
Your blog post content Your blog post content

It will be easier to start drafting your post by using a existing post file as your template, for example, this one

Keep all filenames lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor.md instead of 2017-10-06-WeChat PC Impactor.md

Embed video/pdf from YouTube/Bilibili/local (if there's any) by using {% include iframe.html src="URL_or_PATH" %}. (Learn more about how to embed file/url in the post by reading this blog post

Save photo to local before publishing, to a folder named by ${MONTH}-${YOUR_BLOG_SLUG}/ under /assets/2021/ directory.

Select a beautiful and meaningful teaser image for your blog

Create your contributor profile (if you are a first time contributor)

For excample:

jekyll/_contributors/lijiarui.md


name: Jiarui LI (李佳芮)
site: https://lijiarui.github.io
bio: 句子互动创始人 & CEO,微软人工智能最具价值专家 (AI MVP)
avatar: /jekyll/assets/contributors/lijiarui/avatar.png
email: [email protected]
twitter: https://weibo.com/u/2175505900

Here is the example file:

lijiarui.md: https://github.com/wechaty/wechaty.js.org/blob/master/jekyll/_contributors/lijiarui.md
It will shown like this on wechaty website: https://wechaty.js.org/contributors/lijiarui/
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/

@remember00000 remember00000 requested a review from a team as a code owner July 14, 2021 08:53
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021

CLA assistant check
All committers have signed the CLA.

@remember00000 remember00000 changed the title 基于开放 API 封装 Wechaty 接口下的飞书聊天机器人:期初具体计划 blog request基于开放 API 封装 Wechaty 接口下的飞书聊天机器人:期初具体计划 Jul 14, 2021
@remember00000 remember00000 changed the title blog request基于开放 API 封装 Wechaty 接口下的飞书聊天机器人:期初具体计划 Blog publish request Jul 14, 2021
@remember00000 remember00000 changed the title Blog publish request OSPP 2021: Wechaty Lark Puppet Jul 14, 2021
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the post!

Please:

  1. Sign CLA first
  2. Make GitHub action green. You can run npm run test locally to make it pass the test.
  3. You can ask your mentor help you to review the blog first. When your mentor approve the blog, I will review your blog.


- 熟悉wechaty
- 7.14 - 7.17
- 使用wecharty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Wechaty' here, not 'wecharty'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done~

@Roxanne718
Copy link
Contributor

LGTM

@lijiarui
Copy link
Member

Hi @remember00000 Please make Github action green, then I will review this PR.

You can run npm run test locally to make it pass the test.

@Roxanne718 Could you help @remember00000 to make GitHub action green? thanks!

@remember00000
Copy link
Contributor Author

Hi @remember00000 Please make Github action green, then I will review this PR.

You can run npm run test locally to make it pass the test.

@Roxanne718 Could you help @remember00000 to make GitHub action green? thanks!

I try this,but I met something and I can solve that by google;So I ask in Issues,and I hope to run npm run test locally successfully.thanks

@lijiarui
Copy link
Member

Hi @remember00000 As Github Action shown Your error is related to the image issues, you can read the error info and change as the error required.

ok 18 total 197 files checked.
# developer project avatar should be put under assets/contributors/ folder
not ok 19 jekyll/assets/contributors/remember00000/avatar.jpg should exist
  ---
    operator: fail
    at: Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/contributor-profile.spec.ts:91:11)
    stack: |-
      Error: jekyll/assets/contributors/remember00000/avatar.jpg should exist
          at Test.assert [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.fail (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:322:10)
          at Test.bound [as fail] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/contributor-profile.spec.ts:91:11)
  ...
ok 20 total 197 files checked
# developer profile name must be GitHub username
.......
ok 21 7 contributors profile names checked
# misplaced files
ok 22 should no miss placed files. 
# folder _contributors/, _posts/, and assets/ has been moved to `jekyll/` (e.g. _posts/ => jekyll/_posts/)
ok 23 7 deprecated folders checked.
# filename only allow [a-z0-9-_.]
ok 24 total 2252 files checked.
# front matter key `image` must has a value to define the teaser image
ok 25 total 328 files checked
# {% include iframe.html src=... %} should exist in assets/ folder
ok 26 total 328 files checked.
# all remote images linked from the post should be exist.
.
ok 27 total 1 remote image urls checked
# all local images linked from the post should be exist.
not ok 28 "/assets/2021/07-wechaty-puppet-lark-plan-blog/wechaty-lark.png" should exist
  ---
    operator: fail
    at: Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/image-existance.spec.ts:104:11)
    stack: |-
      Error: "/assets/2021/07-wechaty-puppet-lark-plan-blog/wechaty-lark.png" should exist
          at Test.assert [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.fail (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:322:10)
          at Test.bound [as fail] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/image-existance.spec.ts:104:11)
  ...
not ok 29 "/assets/contributors/remember00000/avatar.jpg" should exist
  ---
    operator: fail
    at: Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/image-existance.spec.ts:104:11)
    stack: |-
      Error: "/assets/contributors/remember00000/avatar.jpg" should exist
          at Test.assert [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:228:54)
          at Test.bound [as _assert] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.fail (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:322:10)
          at Test.bound [as fail] (/home/runner/work/wechaty.js.org/wechaty.js.org/node_modules/tape/lib/test.js:80:32)
          at Test.<anonymous> (/home/runner/work/wechaty.js.org/wechaty.js.org/tests/jekyll/image-existance.spec.ts:104:11)
  ...

As you mention in #1093 It seems this error is totally different from the issue you report, if you can give reproduce code, I would like to help.

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making Github Action green!

Please change as I request, and it would be better if you can refer https://github.com/wechaty/wechaty.js.org/pull/1078/files to make the blog more beautiful/

---
title: "基于开放 API 封装 Wechaty 接口下的飞书聊天机器人:期初具体计划"
author: remember00000
categories: project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to the following as OSPP Guide required.

categories:
  - project
  - ospp

- puppet-provider
- lark
- summer-of-wechaty
- ecosystem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following tag as OSPP Guide required:

ospp,ospp-2021,plan

- 导师:范蕊

- 学生:马田慧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the project link here: wechaty/summer#38

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change as I request.

Also, please change the file name from jekyll/_posts/2021-07-14-wechaty-puppet-lark-plan-blog.md to 2021-07-14-ospp-plan-XXas https://wechaty.js.org/2021/06/24/summer-wechaty-guide/ required.

@@ -0,0 +1,73 @@
---
title: "基于开放 API 封装 Wechaty 接口下的飞书聊天机器人:期初具体计划"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change title to OSPP 2021-期初报告-你的标题 as https://wechaty.js.org/2021/06/24/summer-wechaty-guide/ required.

@lijiarui
Copy link
Member

@remember00000 Please make Github action green.

@lijiarui lijiarui merged commit 3ede701 into wechaty:master Jul 27, 2021
@lijiarui
Copy link
Member

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited remember00000 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add my: wechat: ruirui_0914 and send this pr link to me. I will invite you into Wechaty Contributor Room

Link to wechaty/PMC#16

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants