Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

实际使用中遇到的问题的一些修改，经过测试。 #29

Merged
merged 1 commit into from
Aug 9, 2021
Merged

实际使用中遇到的问题的一些修改，经过测试。 #29

merged 1 commit into from
Aug 9, 2021

Conversation

BruceQiu1996
Copy link
Contributor

1.增加了对于wechaty内部发送数据的实现（结构存在问题，其他部分已经有实现，但是需要重构，不然在使用发送消息的时候很容易报错，进行不下去.
2.获取发送的图片消息时，提示使用messageStream api，使用另外一个grcp的方法，
老代码并没有实现，提供了实现，并且测试使用没问题。

@BruceQiu1996
1.增加了对于wechaty内部发送数据的实现（结构存在问题，其他部分已经有实现，但
feef160 
是需要重构，不然在使用发送消息的时候很容易报错，进行不下去）
    2.获取发送的图片消息时，提示使用messageStream api，使用另外一个grcp的方法，
老代码并没有实现，提供了实现，并且测试使用没问题。
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@huan
Copy link
Member

huan commented Aug 8, 2021

Awesome, thank you very much for the contribution!

Please sign the CLA by clicking the [CLA | not signed yet] button above, then we will be able to review this PR.

@huan huan requested review from echofool and Jesn and removed request for echofool August 8, 2021 17:03
echofool
echofool approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@echofool echofool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echofool echofool merged commit 0ae062f into wechaty:master Aug 9, 2021
Jesn
Jesn reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@Jesn Jesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@Jesn
Copy link
Contributor

Jesn commented Aug 9, 2021

nuget version updated to 0.1.7

@huan
Copy link
Member

huan commented Aug 9, 2021

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited BruceQiu1996 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

@BruceQiu1996
Copy link
Contributor Author

WOW that's great.

@BruceQiu1996 BruceQiu1996 mentioned this pull request Aug 9, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesn Jesn Jesn left review comments

@echofool echofool echofool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BruceQiu1996 @CLAassistant @huan @Jesn @echofool