Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change python proto package name #58

Merged
merged 2 commits into from
Apr 29, 2020
Merged

change python proto package name #58

merged 2 commits into from
Apr 29, 2020

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Apr 27, 2020

change merge-proto.sh package name: wechaty.puppet to wechaty

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@huan
Copy link
Member

huan commented Apr 27, 2020

Thanks for finding the python package name, and I'm looking forward to seeing the Python Hostie implementation!

Please:

  1. Sign the CLA, and
  2. Bump the version in the package.json so that there PyPI package can be automatically published after your PR has been merged.

@huan
Copy link
Member

huan commented Apr 29, 2020

kindly ping @wj-Mcat

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Apr 29, 2020

@huan The problems seems to be grpc-tools package in nodejs.

@huan
Copy link
Member

huan commented Apr 29, 2020

Yes you are right, thanks for pointing it out.

So let's merge it and I'll check the node later.

@huan huan merged commit 5d3f6b2 into wechaty:master Apr 29, 2020
@huan
Copy link
Member

huan commented May 6, 2020

Link to #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wj-Mcat @CLAassistant @huan