-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add corp base info to contact #109
Conversation
I came up with a new name for our If the Other options are:
Refer here I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking the name carefully! that's a very important and hard work for our programmers!
coworker
is very good, I like it too.
However, after reviewing the code I feel there is better to use the full name for our payloads because almost all names in Wechaty source code are using the full name, the pros of the full name are easy to understand and less ambiguity. For example, corp
has two meanings in English.
So, please:
- change
corp
tocorporation
- change
desc
todescription
After we rename them to their full names, then this PR will be good to go.
Full name changed. |
Shall we publish a stable version after we've added these changes? |
My bad, forgot to change the name across all changes :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Look great, merged, thanks for adding those WXWork related properties for our puppet system! |
Related to issue wechaty/wechaty#2036