-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change methods arguments to be nullable #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why do we have a contactPhone
set method but have no contactcorporationRemark
set method?
We do have set method for |
We have three new payloads: phone, description, and corporationRemark. You mean 2 of them are in the payload but the other is not? Should we put them all into the payload, or remove them all out of the payload, I mean, treat them all the same class citizen? |
Yes, the |
I'd like to keep them the same class because they are very similar payload properties, aren't they? So let's put the |
Yep, I think you are right, modified the code according to the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the array optionally property then we will be able to merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for the improvement! |
Align definition with wechaty/grpc#81
Also use
null
value to clear the corporation remark or description.