Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug of issue: wechaty/python-wechaty#120, which caused by FileBox… #33

Merged
merged 3 commits into from
Sep 15, 2020
Merged

fix bug of issue: wechaty/python-wechaty#120, which caused by FileBox… #33

merged 3 commits into from
Sep 15, 2020

Conversation

YangTe1
Copy link
Contributor

@YangTe1 YangTe1 commented Sep 13, 2020

fix bug of issue: wechaty/python-wechaty#120, which caused by FileBoxType difference

之前那个链接为了弄CLA要改以前所有commit的user和email，不小心搞崩了，重开了一个pull request

@YangTe1 YangTe1 requested a review from a team as a code owner September 13, 2020 17:41
@YangTe1
Copy link
Contributor Author

YangTe1 commented Sep 14, 2020

Link to wechaty/PMC#16

不好意思，之前那个链接为了弄CLA要改之前commit的user和email，不小心搞崩了，重开了一个pull request @wj-Mcat

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Sep 14, 2020

There are many types of message, this code is not robust. We provide a from_json method to hand the object converting things.

Plese use this method to convert filebox json object. Thanks a lot.

@YangTe1
Copy link
Contributor Author

YangTe1 commented Sep 14, 2020

Ya, that's a better way.

wj-Mcat
wj-Mcat approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat wj-Mcat merged commit ff4fb07 into wechaty:master Sep 15, 2020
@huan
Copy link
Member

huan commented Nov 7, 2020

Hello @YangTe1 , thank you very much for sending this pull request for improving our Python Wechaty codebase!

I have sent you an invitation for joining our @wechaty/contributors team, please accept it by visiting https://github.com/wechaty

You've invited YangTe1 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

And we also have a WeChat group for all Wechaty Contributors, please contact @lijiarui if you'd like to join.

Have a good night!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wj-Mcat wj-Mcat wj-Mcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YangTe1 @wj-Mcat @huan