-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blue-tape -> node-tap #2223
blue-tape -> node-tap #2223
Conversation
Thank you for the contrinbution. However, I can not understand it, so could you please explain why you submit this PR? What's the problem with the current version of code, and what solution you are trying to make? |
blue-tape is deprecated, and it relys on tape, instead of use tape with node-tap, I think only use node-tap is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the blue-tap
has been deprecated.
Please help me to understand you by replying to my two comments, resolve the conflicts, and then I believe we can continue to review them.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following my review comments!
There are some more issues need to be fixed in this PR, please fix them before we can continue reviewing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
I noticed that we have void
before tests and I have reproduced the problems if we remove them.
We need to find a better way to avoid adding void
in our tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for all the great works for converting the Wechaty testing framework from blue-tape
to the latest version of tap
!
It seems that we still have some issues about the tap
and also need some improvement, but this PR can be merged for now.
Appreciate it!
I haven't found a better solution to resolve the problem , as these test use callback style with async function, if there's one that requires more code change I think. |
Thank you very much for your contribution! You are welcome to join Wechaty Contributor Program1. Join Wechaty Organization
I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16) 2. Update Your Wechaty Contributor Profile
3. Join The Contributor Only WeChat RoomWe also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested. Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room Cheers! |
Checklist
Description